-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding Homer Simpson to docs (#155) #162
Conversation
Codecov ReportAll modified lines are covered by tests ✅ 📢 Thoughts on this report? Let us know!. |
This reverts commit 13c1ffd.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a fun example! Awesome work. Made some comments where more documentation could be helpful, and approving to unblock you, assuming you'll address those.
I don't know if you and Diogo had already discussed this, but do you think it would be helpful to port the full text/images/examples from https://fixinghomer.com/ into this gallery example as well?
docs update Co-authored-by: charles <[email protected]>
Thanks @charlesincharge and @conditg -- just merged #163 |
Thanks Diogo. @conditg I think you'll need to merge in |
* various documentation changes and corrections * homer example * Fixing Homer Example added * reversion commit * formatting with lint * formatting with lint * added color scale control to steady state renders * Revert "added color scale control to steady state renders" This reverts commit 13c1ffd. * removed comment * Update docs/examples/plot_homer.py docs update Co-authored-by: charles <[email protected]> * fixed documentation commenting * fixed dead link --------- Co-authored-by: charles <[email protected]>
Introduction
Adds the Homer Simpson notebook as an example in the NDK docs
Changes
Adds the Homer Simpson notebook as an example in the NDK docs
Behavior
Docs should build successfully, and the new examples is available on the Examples page