Adding Homer Simpson to docs (#155) #162
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified lines are covered by tests ✅ 📢 Thoughts on this report? Let us know!. |
This reverts commit 13c1ffd.
charlesbmi
approved these changes
Oct 5, 2023
There was a problem hiding this comment.
This is a fun example! Awesome work. Made some comments where more documentation could be helpful, and approving to unblock you, assuming you'll address those.
I don't know if you and Diogo had already discussed this, but do you think it would be helpful to port the full text/images/examples from https://fixinghomer.com/ into this gallery example as well?
docs update Co-authored-by: charles <[email protected]>
charlesbmi
added
enhancement
|
Thanks @charlesincharge and @conditg -- just merged #163 |
|
Thanks Diogo. @conditg I think you'll need to merge in |
NewtonSander
pushed a commit
that referenced
this pull request
Jul 26, 2024
* various documentation changes and corrections * homer example * Fixing Homer Example added * reversion commit * formatting with lint * formatting with lint * added color scale control to steady state renders * Revert "added color scale control to steady state renders" This reverts commit 13c1ffd. * removed comment * Update docs/examples/plot_homer.py docs update Co-authored-by: charles <[email protected]> * fixed documentation commenting * fixed dead link --------- Co-authored-by: charles <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduction
Adds the Homer Simpson notebook as an example in the NDK docs
Changes
Adds the Homer Simpson notebook as an example in the NDK docs
Behavior
Docs should build successfully, and the new examples is available on the Examples page