-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add favicon and og image #155
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
seems like we're not able to see ogimage previews on these links because nextauth demand that visitors to the ogimage url be authenticated (favicon works for me, likely cause it was excluded in nextauth) after digging a little deeper, it seems we might not need a configuration pattern like "auth for all pages except xyz", but should instead go for "auth required for pages abc" let's update middleware to only require auth for the path cc @Jaylin0312 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks for investigating, made the change to our middleware and checked that og image is working using linkedin post inspector |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
CLGTM @ f48074e!
added og image (fil- based) and favicon
cant seem to test og image on preview branches but the meta tags are there when we inspect the page