Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feat] load favicon and generic page metadata #141

Closed
davidlhw opened this issue May 26, 2024 · 1 comment · Fixed by #155
Closed

[Feat] load favicon and generic page metadata #141

davidlhw opened this issue May 26, 2024 · 1 comment · Fixed by #155
Assignees
@jeromeandrewong
Labels
enhancement New user-facing feature or request. This Label is used as a category on release notes. good first issue Good for newcomers help wanted Extra attention is needed UI Frontend & User Interface Related

Comments

@davidlhw
Copy link
Contributor

Features

Core

  • favicon (exported from figma)
  • og image (exported from figma)
  • used throughout the app

Optional

  • page specific metadata

Implementation

Potential Issues
@davidlhw davidlhw added enhancement New user-facing feature or request. This Label is used as a category on release notes. good first issue Good for newcomers help wanted Extra attention is needed UI Frontend & User Interface Related labels May 26, 2024
@jeromeandrewong jeromeandrewong self-assigned this May 31, 2024
@davidlhw davidlhw linked a pull request Jun 11, 2024 that will close this issue
feat: add favicon and og image #155
Merged
@davidlhw
Copy link
Contributor Author

closed with #155

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jeromeandrewong jeromeandrewong

Labels
enhancement New user-facing feature or request. This Label is used as a category on release notes. good first issue Good for newcomers help wanted Extra attention is needed UI Frontend & User Interface Related
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: add favicon and og image afterclass-io/afterclass.io
2 participants
@davidlhw @jeromeandrewong