Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Convert Histogram component to TypeScript #466

Merged
merged 1 commit into from
Jul 14, 2021
Merged

Convert Histogram component to TypeScript #466

merged 1 commit into from
Jul 14, 2021

Conversation

dweemx
Copy link
Contributor

@dweemx dweemx commented Jul 13, 2021

Convert Histogram.jsx component to TypeScript.
Partly completes #456.

@dweemx dweemx added the enhancement New feature or request label Jul 13, 2021
MaybeJustJames
MaybeJustJames approved these changes Jul 14, 2021
View reviewed changes
Copy link
Collaborator

@MaybeJustJames MaybeJustJames left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice changes. Thanks @dweemx

@dweemx dweemx merged commit b0d3352 into develop Jul 14, 2021
@dweemx dweemx deleted the 456-convert_histogram_to_ts branch July 14, 2021 09:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MaybeJustJames MaybeJustJames MaybeJustJames approved these changes

@KrisDavie KrisDavie Awaiting requested review from KrisDavie

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dweemx @MaybeJustJames