Skip to content

Changes towards modularity #71

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jan 15, 2016
Merged

Changes towards modularity #71

merged 5 commits into from
Jan 15, 2016

Conversation

sergeyt
Copy link
Contributor

@sergeyt sergeyt commented Jan 14, 2016

@sergeyt
Copy link
Contributor Author

sergeyt commented Jan 14, 2016

@adrai this PR is ready to merge, please review. Also is it ok to drop release/flowchart.zip file from repository? Usually nobody need to explicitly use zip file and also anyone could download zip or tar file right from github, so I suggest to remove this file.

@sergeyt
Copy link
Contributor Author

sergeyt commented Jan 14, 2016

Also now build script generates UMD library. So *.amd.* files were also removed.

@adrai
Copy link
Owner

adrai commented Jan 14, 2016

nice, i hope i can merge this tomorrow

@sergeyt
Copy link
Contributor Author

sergeyt commented Jan 14, 2016

FYI npm run build is build instruction, please update README.md with better words :)

@sergeyt sergeyt changed the title [WIP] changes towards modularity Changes towards modularity Jan 14, 2016
@adrai
Copy link
Owner

adrai commented Jan 15, 2016

I did not try it, but is it still possible to include the lib the "old-way"?

something like this:
<script src="../release/flowchart.js"></script>

@sergeyt
Copy link
Contributor Author

sergeyt commented Jan 15, 2016

but is it still possible to include the lib the "old-way"

yes, in browser it is exposed as global variable FlowChart.

adrai added a commit that referenced this pull request Jan 15, 2016
Changes towards modularity
@adrai adrai merged commit 923d295 into adrai:master Jan 15, 2016
@sergeyt sergeyt deleted the modularity branch January 15, 2016 17:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants