Skip to content

Explicit dependencies using require #70

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
sergeyt opened this issue Jan 13, 2016 · 6 comments
Open

Explicit dependencies using require #70

sergeyt opened this issue Jan 13, 2016 · 6 comments

Comments

@sergeyt
Copy link
Contributor

sergeyt commented Jan 13, 2016

Please consider to refactor the package code in favor of explicit dependencies (instead of //= preprocessor comments) using require to support webpack/browserify wrokflows. Also please explicitly require raphael and add it package.json dependencies. FYI raphael master branch already supports browserify. IMHO this change will be very useful.

@sergeyt
Copy link
Contributor Author

sergeyt commented Jan 13, 2016

BTW I've made this PR to make js-sequence-diagrams webpack-friendly.

@adrai
Copy link
Owner

adrai commented Jan 14, 2016

PR for flowchart.js are welcome too ;-)

@sergeyt
Copy link
Contributor Author

sergeyt commented Jan 14, 2016

@adrai I've sent PR #71. What do you think about if I revise build scripts just using webpack without using grunt at all and add npm scripts to package.json?

@adrai
Copy link
Owner

adrai commented Jan 14, 2016

ok

@adrai
Copy link
Owner

adrai commented Jan 14, 2016

Do you want to be an official contributor?

@sergeyt
Copy link
Contributor Author

sergeyt commented Jan 14, 2016

Thank you, but I'm afraid that I will not have enough time as usual. webpack and eslint helps me to quickly made PR #71, but I don't know this code well now. Maybe later I could help to fix few issues.

adrai added a commit that referenced this issue Jan 15, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants