-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
Explicit dependencies using require #70
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
BTW I've made this PR to make js-sequence-diagrams webpack-friendly. |
PR for flowchart.js are welcome too ;-) |
ok |
Do you want to be an official contributor? |
Thank you, but I'm afraid that I will not have enough time as usual. webpack and eslint helps me to quickly made PR #71, but I don't know this code well now. Maybe later I could help to fix few issues. |
adrai
added a commit
that referenced
this issue
Jan 15, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Please consider to refactor the package code in favor of explicit dependencies (instead of
//=
preprocessor comments) using require to support webpack/browserify wrokflows. Also please explicitly require raphael and add itpackage.json
dependencies
. FYI raphael master branch already supports browserify. IMHO this change will be very useful.The text was updated successfully, but these errors were encountered: