Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MWPW-157100: Merch card headers as p tags for Accessibility #3080 #461

Closed
wants to merge 3 commits into from
Closed

MWPW-157100: Merch card headers as p tags for Accessibility #3080 #461

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
288f227
MWPW-157100: Merch card headers as p tags for Accessibility #3080
Axelcureno Oct 31, 2024
6469287
renamed heading selectors
Axelcureno Oct 31, 2024
4a996d8
typo fixes
Axelcureno Oct 31, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 12 additions & 13 deletions selectors/milo/merchcard.block.page.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,25 +36,24 @@ export default class Merchcard {
this.linkText2 = this.segmentDescription2.locator('a').nth(1);

// merch-card special offers
this.sepcialOffersImage = this.sepcialOffers.locator('div[slot="bg-image"] img');
this.sepcialOffersRibbon = this.merchCard.locator('.special-offers-badge');
this.sepcialOffersTitleH4 = this.sepcialOffers.locator('h4[slot="detail-m"]').nth(0);
this.sepcialOffersTitleH5 = this.sepcialOffers.locator('h5[slot="body-xs"]');
this.sepcialOffersTitleH3 = this.sepcialOffers.locator('h3[slot="heading-xs"]').nth(0);
this.specialOffersImage = this.sepcialOffers.locator('div[slot="bg-image"] img');
this.specialOffersRibbon = this.merchCard.locator('.special-offers-badge');
this.plansCardDetailM = this.sepcialOffers.locator('p[slot="detail-m"]').nth(0);
this.specialOffersTitlePromoText = this.sepcialOffers.locator('p[slot="body-xxs"]');
this.specialOffersTitleHeading = this.sepcialOffers.locator('h3[slot="heading-xs"]').nth(0);

this.sepcialOffersDescription1 = this.sepcialOffers.locator('div[slot="body-xs"] p').nth(1);
this.sepcialOffersDescription2 = this.sepcialOffers.locator('div[slot="body-xs"] p').nth(2);
this.sepcialOffersDescription3 = this.sepcialOffers.locator('div[slot="body-xs"] p').nth(3);
this.sepcialOffersLinkText3 = this.sepcialOffersDescription3.locator('a').nth(0);
this.specialOffersDescription1 = this.sepcialOffers.locator('div[slot="body-xs"] p').nth(1);
this.specialOffersDescription2 = this.sepcialOffers.locator('div[slot="body-xs"] p').nth(2);
this.specialOffersDescription3 = this.sepcialOffers.locator('div[slot="body-xs"] p').nth(3);
this.specialOffersLinkText3 = this.specialOffersDescription3.locator('a').nth(0);

this.seeTermsTextLink = this.merchCard.locator('a:has-text("See terms")');

// merch-card plans locators
this.productIcon = this.plans.locator('img');
this.plansRibbon = this.plans.locator('.plans-badge');
this.plansCardTitleH3 = this.plans.locator('h3[slot="heading-xs"]');
this.plansCardTitleH4 = this.plans.locator('h4[slot="body-xxs"]');
this.plansCardTitleH5 = this.plans.locator('h5[slot="body-xxs"]');
this.plansCardTitleHeadingXS = this.plans.locator('h3[slot="heading-xs"]');
this.plansCardTitlePromoText = this.plans.locator('p[slot="body-xxs"]');
this.plansCardDescription1 = this.plans.locator('div[slot="body-xs"] p').nth(1);
this.plansCardDescription2 = this.plans.locator('div[slot="body-xs"] p').nth(2);
this.plansCardDescription3 = this.plans.locator('div[slot="body-xs"] p').nth(3);
Expand All @@ -73,7 +72,7 @@ export default class Merchcard {
this.systemRequirementTextLink = this.merchCard.locator('a:has-text("See system requirements")');

this.catalogCardTitleH3 = this.catalog.locator('h3[slot="heading-xs"]');
this.catalogCardTitleH4 = this.catalog.locator('h4[slot="body-xxs"]');
this.catalogCardTitleH4 = this.catalog.locator('p[slot="body-xxs"]');
this.catalogCardDescription2 = this.catalog.locator('div[slot="body-xs"] p').nth(2);
this.seeWhatsIncludedTextLink = this.merchCard.locator('a:has-text("See what’s included")');
this.learnMoreTextLink = this.merchCard.locator('a:has-text("Learn more")');
Expand Down
18 changes: 9 additions & 9 deletions tests/milo/merchcard.block.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -95,9 +95,9 @@ test.describe('Milo Merchcard block test suite', () => {
await expect(await merchCard.sepcialOffers).toBeVisible();
await expect(await merchCard.sepcialOffersImage).toBeVisible();

await expect(await merchCard.sepcialOffersTitleH4).toBeVisible();
await expect(await merchCard.sepcialOffersTitleH4).toContainText(data.titleH4);
await expect(await merchCard.sepcialOffersTitleH3).toContainText(data.titleH3);
await expect(await merchCard.plansCardDetailM).toBeVisible();
await expect(await merchCard.plansCardDetailM).toContainText(data.titleH4);
await expect(await merchCard.specialOffersTitleHeading).toContainText(data.titleH3);

await expect(await merchCard.sepcialOffersDescription1).toContainText(data.description1);
await expect(await merchCard.sepcialOffersDescription2).toContainText(data.description2);
Expand Down Expand Up @@ -126,8 +126,8 @@ test.describe('Milo Merchcard block test suite', () => {
await expect(await merchCard.sepcialOffersRibbon).toBeVisible();
await expect(await merchCard.sepcialOffersRibbon).toContainText(data.badgeText);

await expect(await merchCard.sepcialOffersTitleH3).toContainText(data.titleH3);
await expect(await merchCard.sepcialOffersTitleH4).toContainText(data.titleH4);
await expect(await merchCard.specialOffersTitleHeading).toContainText(data.titleH3);
await expect(await merchCard.plansCardDetailM).toContainText(data.titleH4);

await expect(await merchCard.sepcialOffersDescription1).toContainText(data.description);
await expect(await merchCard.seeTermsTextLink).toContainText(data.link1Text);
Expand Down Expand Up @@ -163,7 +163,7 @@ test.describe('Milo Merchcard block test suite', () => {
await expect(await merchCard.plans).toBeVisible();
await expect(await merchCard.productIcon).toBeVisible();

await expect(await merchCard.plansCardTitleH3).toContainText(data.titleH3);
await expect(await merchCard.plansCardTitleHeadingXS).toContainText(data.titleH3);
await expect(await merchCard.plansCardTitleH5).toContainText(data.titleH5);

// await expect(await merchCard.price).toContainText(data.price);
Expand Down Expand Up @@ -195,7 +195,7 @@ test.describe('Milo Merchcard block test suite', () => {
await expect(await merchCard.plansRibbon).toBeVisible();
await expect(await merchCard.plansRibbon).toContainText(data.badgeText);

await expect(await merchCard.plansCardTitleH3).toContainText(data.titleH3);
await expect(await merchCard.plansCardTitleHeadingXS).toContainText(data.titleH3);
await expect(await merchCard.plansCardTitleH4).toContainText(data.titleH4);

// await expect(await merchCard.price).toContainText(data.price);
Expand Down Expand Up @@ -224,7 +224,7 @@ test.describe('Milo Merchcard block test suite', () => {
await expect(await merchCard.plans).toBeVisible();
await expect(await merchCard.productIcon).toBeVisible();

await expect(await merchCard.plansCardTitleH3).toContainText(data.titleH3);
await expect(await merchCard.plansCardTitleHeadingXS).toContainText(data.titleH3);
await expect(await merchCard.plansCardTitleH5).toContainText(data.titleH5);

// await expect(await merchCard.price).toContainText(data.price);
Expand Down Expand Up @@ -258,7 +258,7 @@ test.describe('Milo Merchcard block test suite', () => {
await expect(await merchCard.plansRibbon).toBeVisible();
await expect(await merchCard.plansRibbon).toContainText(data.badgeText);

await expect(await merchCard.plansCardTitleH3).toContainText(data.titleH3);
await expect(await merchCard.plansCardTitleHeadingXS).toContainText(data.titleH3);
await expect(await merchCard.plansCardTitleH5).toContainText(data.titleH5);

// await expect(await merchCard.price).toContainText(data.price);
Expand Down
Loading