MWPW-157100: Merch card headers as p tags for Accessibility #3080 #461
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Roycethan
approved these changes
Oct 31, 2024
yesil
reviewed
Oct 31, 2024
| this.sepcialOffersTitleH4 = this.sepcialOffers.locator('h4[slot="detail-m"]').nth(0); | ||
| this.sepcialOffersTitleH5 = this.sepcialOffers.locator('h5[slot="body-xs"]'); | ||
| this.sepcialOffersTitleH4 = this.sepcialOffers.locator('p[slot="detail-m"]').nth(0); | ||
| this.sepcialOffersTitleH5 = this.sepcialOffers.locator('div[slot="body-xs"]'); |
There was a problem hiding this comment.
btw, for consistency I think you should rename the variables this.sepcialOffersTitleH*, as they are not mapping to a header anymore.
There was a problem hiding this comment.
Good point. I've made the change.
JackySun9
approved these changes
Oct 31, 2024
skumar09
reviewed
Oct 31, 2024
There was a problem hiding this comment.
PR looks good,
@Axelcureno : can you please raise this PR to milo repo for merchcard block,
Info: Milo tests are moved to Milo Repo, and Nala repo will have only Milo consuming application automation scripts.
|
Closing this PR since merch card block NALA tests has been moved to Milo repo. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes the tag names of all headings to
<p>except for the first heading<h3>as per accessibility requirements, as changed in this milo PR: adobecom/milo#3080