MWPW-159374: Support MAS switch to Prosemirror RTE #3117

yesil · 2024-10-30T16:07:38Z

This PR updates the merch-card hydration logic from an AEM fragment, resolving the new markup for the different CTA styles.

Also added new tests, increased test coverage.

see: adobecom/mas#79 for more details.

Resolves:
MWPW-159374

Test URLs:

to support all cta styles organise code and code coverage Update tests

aem-code-sync · 2024-10-30T16:07:42Z

Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed.
In case there are problems, just click a checkbox below to rerun the respective action.

Re-run PSI checks
Re-sync branch

Commits

70bdaf9 ✅ (latest)
ca1f4da ✅
aa229f3 ✅
d84159b ✅
d7948a6 ✅
804dfe2 ✅
05d6b03 ✅
71d34fb ✅
33e802c ✅
9037667 ✅

aem-code-sync · 2024-10-30T16:08:06Z

	Page	Scores	Audits	Google
📱	/drafts/ilyas/merch-card?martech=off
🖥️	/drafts/ilyas/merch-card?martech=off

github-actions

Remaining comments which cannot be posted as a review comment to avoid GitHub Rate Limit

eslint

⚠️ [eslint] _{reported by reviewdog 🐶}
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

https://github.com/adobecom/milo/blob/33e802c94dcde0eef896cc8b6d519baa8f4bc5db/libs/features/mas/web-components/src/variants/catalog.js

⚠️ [eslint] _{reported by reviewdog 🐶}
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

https://github.com/adobecom/milo/blob/33e802c94dcde0eef896cc8b6d519baa8f4bc5db/libs/features/mas/web-components/src/variants/ccd-action.js

⚠️ [eslint] _{reported by reviewdog 🐶}
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

https://github.com/adobecom/milo/blob/33e802c94dcde0eef896cc8b6d519baa8f4bc5db/libs/features/mas/web-components/src/variants/ccd-slice.js

⚠️ [eslint] _{reported by reviewdog 🐶}
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

https://github.com/adobecom/milo/blob/33e802c94dcde0eef896cc8b6d519baa8f4bc5db/libs/features/mas/web-components/src/variants/ccd-suggested.js

⚠️ [eslint] _{reported by reviewdog 🐶}
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

https://github.com/adobecom/milo/blob/33e802c94dcde0eef896cc8b6d519baa8f4bc5db/libs/features/mas/web-components/src/variants/special-offer.js

⚠️ [eslint] _{reported by reviewdog 🐶}
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

https://github.com/adobecom/milo/blob/33e802c94dcde0eef896cc8b6d519baa8f4bc5db/libs/features/mas/web-components/test/hydrate.test.js

⚠️ [eslint] _{reported by reviewdog 🐶}
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

https://github.com/adobecom/milo/blob/33e802c94dcde0eef896cc8b6d519baa8f4bc5db/libs/features/mas/web-components/test/mas.js

github-actions · 2024-10-30T16:08:15Z

libs/deps/mas/commerce.js

⚠️ [eslint] _{reported by reviewdog 🐶}
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

github-actions · 2024-10-30T16:08:16Z

libs/deps/mas/mas.js

⚠️ [eslint] _{reported by reviewdog 🐶}
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

github-actions · 2024-10-30T16:08:17Z

libs/deps/mas/merch-card.js

⚠️ [eslint] _{reported by reviewdog 🐶}
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

github-actions · 2024-10-30T16:08:18Z

libs/features/mas/commerce/src/checkout-link.js

⚠️ [eslint] _{reported by reviewdog 🐶}
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

github-actions · 2024-10-30T16:08:19Z

libs/features/mas/commerce/src/inline-price.js

⚠️ [eslint] _{reported by reviewdog 🐶}
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

github-actions · 2024-10-30T16:08:20Z

libs/features/mas/commerce/test/checkout.test.js

⚠️ [eslint] _{reported by reviewdog 🐶}
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

github-actions · 2024-10-30T16:08:21Z

libs/features/mas/commerce/test/price.test.js

⚠️ [eslint] _{reported by reviewdog 🐶}
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

github-actions · 2024-10-30T16:08:22Z

libs/features/mas/mas/dist/mas.js

⚠️ [eslint] _{reported by reviewdog 🐶}
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

github-actions · 2024-10-30T16:08:23Z

libs/features/mas/web-components/src/global.css.js

⚠️ [eslint] _{reported by reviewdog 🐶}
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

github-actions · 2024-10-30T16:08:24Z

libs/features/mas/web-components/src/hydrate.js

⚠️ [eslint] _{reported by reviewdog 🐶}
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

codecov · 2024-10-30T16:08:58Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.38%. Comparing base (f379815) to head (70bdaf9).
Report is 1 commits behind head on stage.

Additional details and impacted files

@@            Coverage Diff             @@
##            stage    #3117      +/-   ##
==========================================
+ Coverage   96.36%   96.38%   +0.01%     
==========================================
  Files         245      245              
  Lines       56529    56651     +122     
==========================================
+ Hits        54476    54601     +125     
+ Misses       2053     2050       -3

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

github-actions · 2024-10-30T16:11:27Z

libs/features/mas/web-components/src/variants/catalog.js

⚠️ [eslint] _{reported by reviewdog 🐶}
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

github-actions · 2024-10-30T16:11:28Z

libs/features/mas/web-components/src/variants/ccd-action.js

⚠️ [eslint] _{reported by reviewdog 🐶}
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

github-actions · 2024-10-30T16:11:29Z

libs/features/mas/web-components/src/variants/ccd-slice.js

⚠️ [eslint] _{reported by reviewdog 🐶}
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

github-actions · 2024-10-30T16:11:30Z

libs/features/mas/web-components/src/variants/ccd-suggested.js

⚠️ [eslint] _{reported by reviewdog 🐶}
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

github-actions · 2024-10-30T16:11:31Z

libs/features/mas/web-components/src/variants/special-offer.js

⚠️ [eslint] _{reported by reviewdog 🐶}
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

github-actions · 2024-10-30T16:11:31Z

libs/features/mas/web-components/test/hydrate.test.js

⚠️ [eslint] _{reported by reviewdog 🐶}
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

github-actions · 2024-10-30T16:11:32Z

libs/features/mas/web-components/test/mas.js

⚠️ [eslint] _{reported by reviewdog 🐶}
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

github-actions · 2024-10-31T01:38:33Z

This pull request is not passing all required checks. Please see this discussion for information on how to get all checks passing. Inconsistent checks can be manually retried. If a test absolutely can not pass for a good reason, please add a comment with an explanation to the PR.

github-actions · 2024-11-05T01:35:29Z

Reminder to set the Ready for Stage label - to queue this to get merged to stage & production.

afmicka · 2024-11-05T17:48:15Z

@yesil I have verified the PR with the Ready for stage label but the failing coverage check needs to be fixed in order for PR to really be merged. Will be skipped otherwise

milo-pr-merge · 2024-11-06T09:17:15Z

Skipped merging 3117: MWPW-159374: Support MAS switch to Prosemirror RTE due to failing checks

milo-pr-merge · 2024-11-06T10:13:10Z

Skipped 3117: "MWPW-159374: Support MAS switch to Prosemirror RTE" due to file "libs/deps/mas/mas.js" overlap. Merging will be attempted in the next batch

milo-pr-merge · 2024-11-07T18:44:51Z

Skipped 3117: "MWPW-159374: Support MAS switch to Prosemirror RTE" due to file "libs/deps/mas/mas.js" overlap. Merging will be attempted in the next batch

yesil added 2 commits October 30, 2024 14:01

MWPW-159374: Update hydrate logic

9037667

to support all cta styles organise code and code coverage Update tests

add workaround for ccd-suggested cards

33e802c

yesil added run-nala Run Nala Test Automation against PR commerce labels Oct 30, 2024

github-actions bot reviewed Oct 30, 2024

View reviewed changes

remove source maps

71d34fb

aem-code-sync bot temporarily deployed to MWPW-159374 October 30, 2024 16:10 Inactive

github-actions bot reviewed Oct 30, 2024

View reviewed changes

yesil mentioned this pull request Oct 30, 2024

MWPW-159374: Replace tinyMCE with Prosemirror adobecom/mas#79

Merged

improve code coverage

05d6b03

Merge branch 'stage' of github.com:adobecom/milo into MWPW-159374

804dfe2

aem-code-sync bot temporarily deployed to MWPW-159374 October 31, 2024 08:59 Inactive

yesil removed the run-nala Run Nala Test Automation against PR label Oct 31, 2024

3ch023 approved these changes Nov 4, 2024

View reviewed changes

yesil mentioned this pull request Nov 4, 2024

MWPW-161355: Update MAS documentation #3135

Merged

Axelcureno approved these changes Nov 4, 2024

View reviewed changes

Merge branch 'stage' of github.com:adobecom/milo into MWPW-159374

d7948a6

aem-code-sync bot temporarily deployed to MWPW-159374 November 5, 2024 08:02 Inactive

yesil assigned afmicka Nov 5, 2024

yesil added 2 commits November 5, 2024 15:09

cleanup all attributes during card hydration

d84159b

Merge branch 'stage' of github.com:adobecom/milo into MWPW-159374

aa229f3

afmicka added verified PR has been E2E tested by a reviewer Ready for Stage labels Nov 5, 2024

Merge branch 'stage' of github.com:adobecom/milo into MWPW-159374

ca1f4da

Merge branch 'stage' of github.com:adobecom/milo into MWPW-159374

70bdaf9

overmyheadandbody merged commit df454db into stage Nov 8, 2024
14 checks passed

overmyheadandbody deleted the MWPW-159374 branch November 8, 2024 10:31

overmyheadandbody mentioned this pull request Nov 8, 2024

[Release] Stage to Main #3160

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

MWPW-159374: Support MAS switch to Prosemirror RTE #3117

MWPW-159374: Support MAS switch to Prosemirror RTE #3117

yesil commented Oct 30, 2024 •

edited

Loading

aem-code-sync bot commented Oct 30, 2024 •

edited

Loading

aem-code-sync bot commented Oct 30, 2024 •

edited

Loading

github-actions bot left a comment

github-actions bot Oct 30, 2024

github-actions bot Oct 30, 2024

github-actions bot Oct 30, 2024

github-actions bot Oct 30, 2024

github-actions bot Oct 30, 2024

github-actions bot Oct 30, 2024

github-actions bot Oct 30, 2024

github-actions bot Oct 30, 2024

github-actions bot Oct 30, 2024

github-actions bot Oct 30, 2024

codecov bot commented Oct 30, 2024 •

edited

Loading

github-actions bot Oct 30, 2024

github-actions bot Oct 30, 2024

github-actions bot Oct 30, 2024

github-actions bot Oct 30, 2024

github-actions bot Oct 30, 2024

github-actions bot Oct 30, 2024

github-actions bot Oct 30, 2024

github-actions bot commented Oct 31, 2024

github-actions bot commented Nov 5, 2024

afmicka commented Nov 5, 2024 •

edited

Loading

milo-pr-merge bot commented Nov 6, 2024

milo-pr-merge bot commented Nov 6, 2024

milo-pr-merge bot commented Nov 7, 2024

MWPW-159374: Support MAS switch to Prosemirror RTE #3117

MWPW-159374: Support MAS switch to Prosemirror RTE #3117

Conversation

yesil commented Oct 30, 2024 • edited Loading

aem-code-sync bot commented Oct 30, 2024 • edited Loading

aem-code-sync bot commented Oct 30, 2024 • edited Loading

github-actions bot left a comment

Choose a reason for hiding this comment

github-actions bot Oct 30, 2024

Choose a reason for hiding this comment

github-actions bot Oct 30, 2024

Choose a reason for hiding this comment

github-actions bot Oct 30, 2024

Choose a reason for hiding this comment

github-actions bot Oct 30, 2024

Choose a reason for hiding this comment

github-actions bot Oct 30, 2024

Choose a reason for hiding this comment

github-actions bot Oct 30, 2024

Choose a reason for hiding this comment

github-actions bot Oct 30, 2024

Choose a reason for hiding this comment

github-actions bot Oct 30, 2024

Choose a reason for hiding this comment

github-actions bot Oct 30, 2024

Choose a reason for hiding this comment

github-actions bot Oct 30, 2024

Choose a reason for hiding this comment

codecov bot commented Oct 30, 2024 • edited Loading

Codecov Report

github-actions bot Oct 30, 2024

Choose a reason for hiding this comment

github-actions bot Oct 30, 2024

Choose a reason for hiding this comment

github-actions bot Oct 30, 2024

Choose a reason for hiding this comment

github-actions bot Oct 30, 2024

Choose a reason for hiding this comment

github-actions bot Oct 30, 2024

Choose a reason for hiding this comment

github-actions bot Oct 30, 2024

Choose a reason for hiding this comment

github-actions bot Oct 30, 2024

Choose a reason for hiding this comment

github-actions bot commented Oct 31, 2024

github-actions bot commented Nov 5, 2024

afmicka commented Nov 5, 2024 • edited Loading

milo-pr-merge bot commented Nov 6, 2024

milo-pr-merge bot commented Nov 6, 2024

milo-pr-merge bot commented Nov 7, 2024

yesil commented Oct 30, 2024 •

edited

Loading

aem-code-sync bot commented Oct 30, 2024 •

edited

Loading

aem-code-sync bot commented Oct 30, 2024 •

edited

Loading

codecov bot commented Oct 30, 2024 •

edited

Loading

afmicka commented Nov 5, 2024 •

edited

Loading