MWPW-159374: Replace tinyMCE with Prosemirror #79
Conversation
|
Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed.
Commits
|
|
I have some OST changes as well, I'll open a PR tomorrow. |
|
seeing overlap |
studio/src/ost.js
Outdated
| @@ -138,6 +138,7 @@ export function getOffferSelectorTool() { | |||
| <div id="ost"></div> | |||
| </sp-dialog-wrapper> | |||
| </overlay-trigger> | |||
There was a problem hiding this comment.
is </overlay-trigger> closing tag needed? can't see the opening one
There was a problem hiding this comment.
@3ch023 thanks to you I found dead ost code to cleanup.
| // Function to get the difference between two objects | ||
| function getObjectDifference(values, defaults) { | ||
| const difference = {}; | ||
|
|
There was a problem hiding this comment.
extra spaces her and in line 71
|
@afmicka updates in the editor should be fixed now. |
|
@yesil Leaving here the list of issues still present:
expected:
|
|
@yesil studio looks good to me now. Will create separate jira for the strikethrough price style The remaining issues i see (but are no regression) are:
Let me know if these issues need a separate jiras or will be addressed here |
|
Issue no 1 fixed, the second created a follow-up jira https://jira.corp.adobe.com/browse/MWPW-161588. |
studio/src/studio.js
Outdated
| @@ -335,7 +332,7 @@ class MasStudio extends LitElement { | |||
| ? html`<mas-filter-panel></mas-filter-panel>` | |||
| : nothing} | |||
| ${this.content} ${this.fragmentEditor} ${this.selectFragmentDialog} | |||
| ${this.toast} ${this.loadingIndicator} ${getOffferSelectorTool()} | |||
| ${this.toast} ${this.loadingIndicator}} | |||
There was a problem hiding this comment.
There's an extra closing curly bracket at eol that should be removed.
There was a problem hiding this comment.
Good catch, thanks @Axelcureno
Resolve:
https://jira.corp.adobe.com/browse/MWPW-159374
https://jira.corp.adobe.com/browse/MWPW-159258
https://jira.corp.adobe.com/browse/MWPW-159259
Milo PR: adobecom/milo#3117
OST PR: https://git.corp.adobe.com/wcms/tacocat.js/pull/645
Test URLs:
PROD: https://mwpw-159374--mas--adobecom.hlx.live/studio.html?milolibs=mwpw-159374--milo--adobecom#query=acom