Mwpw 147034: Custom border color + badge/border color decoupling [merch card] #2613
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed.
|
Axelcureno
added
run-nala
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## stage #2613 +/- ##
==========================================
- Coverage 95.70% 95.70% -0.01%
==========================================
Files 172 172
Lines 45361 45361
==========================================
- Hits 43412 43411 -1
- Misses 1949 1950 +1 ☔ View full report in Codecov by Sentry. |
Roycethan
added
verified
mokimo
approved these changes
Jul 24, 2024
overmyheadandbody
approved these changes
Jul 24, 2024
|
Error merging 2613: Mwpw 147034: Custom border color + badge/border color decoupling [merch card] file is not defined |
|
Skipped 2613: "Mwpw 147034: Custom border color + badge/border color decoupling [merch card]" due to file "libs/deps/merch-card.js" overlap. Merging will be attempted in the next batch |
|
This PR does not qualify for the zero-impact label as it touches code outside of the allowed areas. The label is auto applied, do not manually apply the label. |
rohitsahu
pushed a commit
to rohitsahu/milo
that referenced
this pull request
Jul 29, 2024
* stage: MWPW-150557 - Split Marquee CLS issues on consuming sites (adobecom#2636) Mwpw 147034: Custom border color + badge/border color decoupling [merch card] (adobecom#2613) [MWPW-151517] - Remove condition for promobar hidden on mobile from gnav (adobecom#2538) # Conflicts: # libs/deps/merch-card.js
rohitsahu
pushed a commit
to rohitsahu/milo
that referenced
this pull request
Jul 30, 2024
* stage: [MWPW-153611] [Gray Box] environment aware links (adobecom#2622) MWPW-153580: Add Opt-In Feature for CaaS Badge Display (adobecom#2625) [MWPW-154335] [callout] Spacing issue encountered when the call-out section is added (adobecom#2628) MWPW-150557 - Split Marquee CLS issues on consuming sites (adobecom#2636) Mwpw 147034: Custom border color + badge/border color decoupling [merch card] (adobecom#2613) [MWPW-151517] - Remove condition for promobar hidden on mobile from gnav (adobecom#2538) MWPW-154998 [MEP][MILO] Manifests do not execute in the right order when there is a disabled manifest (adobecom#2632) mwpw-154965: Fetch federal stage content from hlx.page instead of stage.adobe.com (adobecom#2618) Correct error messages for duplicate files on the stage to main workflow (adobecom#2621) MWPW-153245 [merch][analytics] dispatch wcomp events, and let default lh (adobecom#2610) Revert "MWPW-146528[MILO][MEP][ANALYTICS] Add attribute to content changed by Target for analytics and MWPW-152274" (adobecom#2627) MWPW-128600 Locale Tool: Langstore points to langstore/en (adobecom#2615) Fix for errors in dynamically loaded scripts in test cases (adobecom#2619) MWPW-146528[MILO][MEP][ANALYTICS] Add attribute to content changed by Target for analytics and MWPW-152274 (adobecom#2593) Bootstrapper script for milo feds blocks (adobecom#2560) Revert "[MWPW-152968] mWeb - Passing ECID to Branch.io banner - Implementation" (adobecom#2612) # Conflicts: # libs/deps/merch-card.js
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds ability to decouple border and badge colors in authoring of merch card.
Adds ability to set custom border color without using a badge in merch card.
This is a dependency consumption PR, milo changes already merged.
Mas PR: adobecom/mas#15
Resolves: MWPW-147034
Test URLs:
Before: https://main--milo--adobecom.hlx.page/drafts/axel/custom-border-badge?martech=off
After: https://mwpw-147034--milo--adobecom.hlx.page/drafts/axel/custom-border-badge?martech=off