Mwpw-147034: Custom border color + badge/border color decoupling [Mer… #15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Axelcureno
added
enhancement
|
Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed.
|
yesil
previously requested changes
Jun 27, 2024
yesil
reviewed
Jun 27, 2024
mirafedas
approved these changes
Jul 22, 2024
|
3ch023
removed
the
VALIDATED IN MILO
|
UPD: |
Roycethan
added
the
VALIDATED IN MILO
rohitsahu
pushed a commit
that referenced
this pull request
Jul 26, 2024
* main: MWPW-153245 [merch] make shadow elements spit custom events (#42) MWPW-148229 Left Rail filter hover Text (#43) Stop using code which resolves default display tax label value per country and segment (#27) Mwpw-147034: Custom border color + badge/border color decoupling [Mer… (#15) MWPW-154026: Long CTAs fall in the second line in merch card footer (#38) # Conflicts: # libs/commerce.js # libs/mas.js # libs/merch-card-all.js # libs/merch-card.js # web-components/src/merch-card.js
rohitsahu
pushed a commit
that referenced
this pull request
Aug 7, 2024
* 'ost' of https://github.com/adobecom/mas: Update mas.js Revert "resolved conflicts" Update mas.js updated deps MWPW-153599: M@S Studio solution design (#36) moved delay method Update package-lock.json Mwpw-151480: move of commerce and web components to milo (#49) [MWPW-154335] [callout] Spacing issue encountered when the call-out section is added (#45) MWPW-153245 [merch] make shadow elements spit custom events (#42) MWPW-148229 Left Rail filter hover Text (#43) Stop using code which resolves default display tax label value per country and segment (#27) Mwpw-147034: Custom border color + badge/border color decoupling [Mer… (#15) MWPW-154026: Long CTAs fall in the second line in merch card footer (#38) # Conflicts: # libs/commerce.js # libs/mas.js
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds ability to decouple border and badge colors in authoring of merch card.
Adds ability to set custom border color without using a badge in merch card.
Resolves: MWPW-147034
Milo PR: adobecom/milo#2613
Test URLs:
Before: https://main--milo--adobecom.hlx.page/drafts/axel/custom-border-badge?martech=off
After: https://mwpw-147034--milo--adobecom.hlx.page/drafts/axel/custom-border-badge?martech=off