Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MWPW-159032: Verb Widget - Accessibility Issues #822

Merged
merged 4 commits into from
Sep 30, 2024
+7 −4
Merged

MWPW-159032: Verb Widget - Accessibility Issues #822

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
ee0c440
Open with enter and focusable with tab key
joaquinrivero Sep 25, 2024
cacd468
Merge branch 'stage' into MWPW-159032
joaquinrivero Sep 25, 2024
d84c52d
Merge branch 'stage' into MWPW-159032
joaquinrivero Sep 25, 2024
8bc58b7
Merge branch 'stage' into MWPW-159032
Blainegunn Sep 30, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions acrobat/blocks/verb-widget/verb-widget.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,6 +55,9 @@
text-align: center;
}

.verb-footer a {
text-decoration: underline;
}

#CIDTWO {
/* display: none; */
Expand Down Expand Up @@ -168,7 +171,7 @@
transform: translate(-50%, -50%);
left: 50%;
font-size: 14px;
font-weight: 400;
font-weight: 400;
}

.verb-errorText {
Expand Down Expand Up @@ -236,7 +239,7 @@
margin-left: 15px;
}

.verb-mobile-cta:hover,
.verb-mobile-cta:hover,
.verb-mobile-cta:active {
background-color: #0054b6;
color: #fff;
Expand Down
4 changes: 2 additions & 2 deletions acrobat/blocks/verb-widget/verb-widget.js
View file
Open in desktop
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ [eslint] <no-console> reported by reviewdog 🐶
Unexpected console statement.

dc/acrobat/blocks/verb-widget/verb-widget.js

Line 141 in 8bc58b7

console.log('IMS:Ready 😎');

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ [eslint] <no-console> reported by reviewdog 🐶
Unexpected console statement.

dc/acrobat/blocks/verb-widget/verb-widget.js

Line 150 in 8bc58b7

console.log('Race Con ⏩');

Original file line number Diff line number Diff line change
Expand Up @@ -101,10 +101,10 @@ export default async function init(element) {
const widgetIcon = createTag('div', { class: 'verb-icon' });
const widgetTitle = createTag('div', { class: 'verb-title' }, 'Acrobat');
const widgetCopy = createTag('p', { class: 'verb-copy' }, window.mph[`verb-widget-${VERB}-description`]);
const widgetButton = createTag('label', { for: 'file-upload', class: 'verb-cta' }, window.mph['verb-widget-cta']);
const widgetButton = createTag('label', { for: 'file-upload', class: 'verb-cta', tabindex: 0 }, window.mph['verb-widget-cta']);
const widgetMobileButton = createTag('a', { class: 'verb-mobile-cta', href: mobileLink }, window.mph['verb-widget-cta-mobile']);
const button = createTag('input', { type: 'file', id: 'file-upload', class: 'hide' });
const widgetImage = createTag('img', { class: 'verb-image', src: `/acrobat/img/verb-widget/${VERB}.png` });
const widgetImage = createTag('img', { class: 'verb-image', src: `/acrobat/img/verb-widget/${VERB}.png`, alt: '' });
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

instead of alt: '' let's do alt: '${VERB}'

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Blainegunn Templating the string is not needed.

// Since we're using placeholders we need a solution for the hyperlinks
const legal = createTag('p', { class: 'verb-legal' }, `${window.mph['verb-widget-legal']} `);
const terms = createTag('a', { class: 'verb-legal-url', target: '_blank', href: 'https://www.adobe.com/legal/terms.html' }, window.mph.tou);
Expand Down
Loading