MWPW-159032: Verb Widget - Accessibility Issues #822
Conversation
Text decoration under verb widget footer links
* stage: Lint fix Eslint fix Dynamic prefetch from anon on unity workflow
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## stage #822 +/- ##
=======================================
Coverage 89.25% 89.25%
=======================================
Files 49 49
Lines 7762 7762
=======================================
Hits 6928 6928
Misses 834 834
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
| const widgetMobileButton = createTag('a', { class: 'verb-mobile-cta', href: mobileLink }, window.mph['verb-widget-cta-mobile']); | ||
| const button = createTag('input', { type: 'file', id: 'file-upload', class: 'hide' }); | ||
| const widgetImage = createTag('img', { class: 'verb-image', src: `/acrobat/img/verb-widget/${VERB}.png` }); | ||
| const widgetImage = createTag('img', { class: 'verb-image', src: `/acrobat/img/verb-widget/${VERB}.png`, alt: '' }); |
There was a problem hiding this comment.
instead of alt: '' let's do alt: '${VERB}'
There was a problem hiding this comment.
@Blainegunn Templating the string is not needed.
| const widgetMobileButton = createTag('a', { class: 'verb-mobile-cta', href: mobileLink }, window.mph['verb-widget-cta-mobile']); | ||
| const button = createTag('input', { type: 'file', id: 'file-upload', class: 'hide' }); | ||
| const widgetImage = createTag('img', { class: 'verb-image', src: `/acrobat/img/verb-widget/${VERB}.png` }); | ||
| const widgetImage = createTag('img', { class: 'verb-image', src: `/acrobat/img/verb-widget/${VERB}.png`, alt: '' }); |
There was a problem hiding this comment.
@Blainegunn Templating the string is not needed.
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Unexpected console statement.
dc/acrobat/blocks/verb-widget/verb-widget.js
Line 141 in 8bc58b7
There was a problem hiding this comment.
Unexpected console statement.
dc/acrobat/blocks/verb-widget/verb-widget.js
Line 150 in 8bc58b7
Resolves: MWPW-159032
Submit accesible by keyboard
Text decoration under verb widget footer links
Test URL: