-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Mwpw 135027 aa tracking on accordion #350
Closed
Closed
Changes from 2 commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
15ef806
MWPW-135027: Changed analytics for faq accordion on frictionless
06ec328
Merge remote-tracking branch 'origin/stage' into MWPW-135027-aa-track…
e53dbe2
Fix unit test
TsayAdobe 348da15
Merge remote-tracking branch 'origin/stage' into MWPW-135027-aa-track…
ffe1e7b
Merge branch 'stage' into MWPW-135027-aa-tracking-on-accordion
Blainegunn 5032342
Merge branch 'stage' into MWPW-135027-aa-tracking-on-accordion
Blainegunn File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,30 @@ | ||
export default function init(fragmentName, state, ctaNumber, text) { | ||
const customLink = [fragmentName.toUpperCase(), state, `${ctaNumber}-${text}`].join('|'); | ||
const event = { | ||
// always trigger the event using navigator.sendBeacon | ||
documentUnloading: true, | ||
data: { | ||
eventType: 'web.webinteraction.linkClicks', | ||
web: { | ||
webInteraction: { | ||
linkClicks: { | ||
value: 1, | ||
}, | ||
type: 'other', | ||
name: customLink, | ||
}, | ||
}, | ||
_adobe_corpnew: { | ||
digitalData: { | ||
primaryEvent: { | ||
eventInfo: { | ||
interaction: {[state]: customLink}, | ||
eventName: customLink, | ||
}, | ||
}, | ||
}, | ||
}, | ||
}, | ||
}; | ||
window._satellite.track('event', event); | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,36 @@ | ||
import { expect } from '@esm-bundle/chai'; | ||
import * as sinon from 'sinon'; | ||
|
||
const { default: init } = await import( | ||
'../../../acrobat/scripts/alloy/accordion' | ||
); | ||
|
||
describe('Alloy accordion', () => { | ||
beforeEach(() => { | ||
window._satellite = { | ||
track: sinon.stub(), | ||
}; | ||
}); | ||
|
||
afterEach(() => { | ||
sinon.restore(); | ||
}); | ||
[ | ||
['faq', 'Expand', 1, 'How do I fill out a form?'], | ||
['faq', 'Expand', 3, 'How can I upload a photo of my signature?'], | ||
['faq', 'Collapse', 1, 'How do I fill out a form?'], | ||
['faq', 'Collapse', 3, 'How can I upload a photo of my signature?'], | ||
|
||
].forEach( | ||
([fragmentName, state, ctaNumber, text]) => { | ||
it('initiates Alloy accordion', () => { | ||
init(fragmentName, state, ctaNumber, text); | ||
const customLink = [fragmentName.toUpperCase(), state, `${ctaNumber}-${text}`].join('|'); | ||
expect( | ||
window._satellite.track.args[0][1].data._adobe_corpnew.digitalData | ||
.primaryEvent.eventInfo.eventName | ||
).to.include(customLink); | ||
}); | ||
} | ||
); | ||
}); |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@TsayAdobe , can you help me ? I tried to write a test for this part of the code that I added, but the code inside
setInterval
isn't executed by the tests. When I call theinit
function from eventwrapper, that is imported inside the tests,setInterval
is skipped and because of that I can not testchangeAccordionAnalytics
function. Can you please take a look ? Thanks.