-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Mwpw 135027 aa tracking on accordion #350
Conversation
Hello, I'm Franklin Bot and I will run some test suites that validate the page speed.
|
|
Codecov Report
@@ Coverage Diff @@
## stage #350 +/- ##
==========================================
+ Coverage 94.55% 98.45% +3.89%
==========================================
Files 23 24 +1
Lines 2589 2646 +57
==========================================
+ Hits 2448 2605 +157
+ Misses 141 41 -100
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
export default function init(element) { | ||
const faqFrag = element.querySelector("a[href*='faq'], div[data-path*='faq']"); | ||
if (faqFrag) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@TsayAdobe , can you help me ? I tried to write a test for this part of the code that I added, but the code inside setInterval
isn't executed by the tests. When I call the init
function from eventwrapper, that is imported inside the tests, setInterval
is skipped and because of that I can not test changeAccordionAnalytics
function. Can you please take a look ? Thanks.
|
|
@zagi25 Please review the test fix and see if it matches your implementation. |
|
@TsayAdobe Thanks a lot for the help ! |
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Resolves: MWPW-135027
Before: https://stage--dc--adobecom.hlx.live/acrobat/online/pdf-to-ppt
After: https://mwpw-135027-aa-tracking-on-accordion--dc--adobecom.hlx.live/acrobat/online/pdf-to-ppt