Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mwpw 135027 aa tracking on accordion #350

Closed
wants to merge 6 commits into from

Conversation

@aem-code-sync
Copy link

aem-code-sync bot commented Aug 29, 2023

Hello, I'm Franklin Bot and I will run some test suites that validate the page speed.
In case there are problems, just click the checkbox below to rerun the respective action.

  • Re-run PSI Checks

@aem-code-sync
Copy link

aem-code-sync bot commented Aug 29, 2023

Page Scores Audits Google
/acrobat/online/pdf-to-ppt PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI

@codecov-commenter
Copy link

codecov-commenter commented Aug 29, 2023

Codecov Report

Merging #350 (5032342) into stage (d5861af) will increase coverage by 3.89%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##            stage     #350      +/-   ##
==========================================
+ Coverage   94.55%   98.45%   +3.89%     
==========================================
  Files          23       24       +1     
  Lines        2589     2646      +57     
==========================================
+ Hits         2448     2605     +157     
+ Misses        141       41     -100     
Files Changed Coverage Δ
acrobat/blocks/eventwrapper/eventwrapper.js 89.00% <100.00%> (+58.71%) ⬆️
acrobat/scripts/alloy/accordion.js 100.00% <100.00%> (ø)
acrobat/scripts/contentSecurityPolicy/dev.js 100.00% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

export default function init(element) {
const faqFrag = element.querySelector("a[href*='faq'], div[data-path*='faq']");
if (faqFrag) {
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@TsayAdobe , can you help me ? I tried to write a test for this part of the code that I added, but the code inside setInterval isn't executed by the tests. When I call the init function from eventwrapper, that is imported inside the tests, setInterval is skipped and because of that I can not test changeAccordionAnalytics function. Can you please take a look ? Thanks.

@aem-code-sync
Copy link

aem-code-sync bot commented Aug 29, 2023

Page Scores Audits Google
/acrobat/online/pdf-to-ppt PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI

@aem-code-sync
Copy link

aem-code-sync bot commented Aug 29, 2023

Page Scores Audits Google
/acrobat/online/pdf-to-ppt PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI

@TsayAdobe
Copy link
Collaborator

@zagi25 Please review the test fix and see if it matches your implementation.

@aem-code-sync
Copy link

aem-code-sync bot commented Aug 30, 2023

Page Scores Audits Google
/acrobat/online/pdf-to-ppt PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI

@zagi25
Copy link
Collaborator Author

zagi25 commented Aug 30, 2023

@TsayAdobe Thanks a lot for the help !

@zagi25 zagi25 added this to the 0.2336 milestone Aug 30, 2023
@aem-code-sync
Copy link

aem-code-sync bot commented Aug 31, 2023

Page Scores Audits Google
/acrobat/online/pdf-to-ppt PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI

@aem-code-sync
Copy link

aem-code-sync bot commented Aug 31, 2023

Page Scores Audits Google
/acrobat/online/pdf-to-ppt PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI

Copy link
Contributor

@puruadobe puruadobe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zagi25 zagi25 closed this Sep 4, 2023
@Blainegunn Blainegunn deleted the MWPW-135027-aa-tracking-on-accordion branch November 14, 2023 18:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants