Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MWPW-158911: Unable to scroll page if the filters modal closed by click outside of the modal #412

Merged
merged 7 commits into from
Oct 21, 2024
Merged

MWPW-158911: Unable to scroll page if the filters modal closed by click outside of the modal #412

Show file tree
Hide file tree
Changes from 4 commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
77082d7
fixed scrolling after click outside
mirafedas Oct 3, 2024
bf71cde
Merge branch 'stage' into mwpw-158911-modal-scroll
Axelcureno Oct 4, 2024
1849274
merch-sidenav is taken from Milo now
mirafedas Oct 8, 2024
a8f32da
debug
mirafedas Oct 8, 2024
d7359b6
debug
mirafedas Oct 8, 2024
5ea573f
debug
mirafedas Oct 8, 2024
a0723a8
fixed libs path in unit tests
mirafedas Oct 9, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion creativecloud/blocks/sidenav/sidenav.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -162,8 +162,10 @@ function appendResources(rootNav, resourceLink) {
export default async function init(el) {
const libs = getLibs();
const [mainRow, categoryRow] = Array.from(el.children);
console.log('libs', libs);
mirafedas marked this conversation as resolved.
Show resolved Hide resolved
console.log('full path', `${libs}/deps/mas/merch-sidenav.js`);
mirafedas marked this conversation as resolved.
Show resolved Hide resolved
const deps = Promise.all([
import('../../deps/merch-sidenav.js'),
import(`${libs}/deps/mas/merch-sidenav.js`),
// eslint-disable-next-line import/no-unresolved, import/no-absolute-path
import(`${libs}/deps/lit-all.min.js`),
import(`${libs}/features/spectrum-web-components/dist/theme.js`),
Expand Down
141 changes: 0 additions & 141 deletions creativecloud/deps/merch-sidenav.js
View file
Open in desktop

This file was deleted.

Loading