MWPW-158911: Unable to scroll page if the filters modal closed by click outside of the modal #412
Conversation
mirafedas
requested review from
yesil,
Axelcureno,
rahulgupta999,
3ch023,
rohitsahu,
bozojovicic and
seanchoi-dev
|
Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed.
|
|
|
@mirafedas can you link the Milo PR? |
|
Skipped merging 412: MWPW-158911: Unable to scroll page if the filters modal closed by click outside of the modal due to failing checks |
|
Skipped merging 412: MWPW-158911: Unable to scroll page if the filters modal closed by click outside of the modal due to missing verified label. kindly make sure that the PR has been verified |
2 similar comments
|
Skipped merging 412: MWPW-158911: Unable to scroll page if the filters modal closed by click outside of the modal due to missing verified label. kindly make sure that the PR has been verified |
|
Skipped merging 412: MWPW-158911: Unable to scroll page if the filters modal closed by click outside of the modal due to missing verified label. kindly make sure that the PR has been verified |
aem-code-sync
bot
temporarily deployed
to
mwpw-158911-modal-scroll
|
Skipped merging 412: MWPW-158911: Unable to scroll page if the filters modal closed by click outside of the modal due to failing checks |
…m/cc into mwpw-158911-modal-scroll
aem-code-sync
bot
temporarily deployed
to
mwpw-158911-modal-scroll
aem-code-sync
bot
temporarily deployed
to
mwpw-158911-modal-scroll
|
Skipped merging 412: MWPW-158911: Unable to scroll page if the filters modal closed by click outside of the modal due to failing checks |
aishwaryamathuria
force-pushed
the
stage
branch
from
f4610ec
to
6ccae68
Compare
|
Skipped merging 412: MWPW-158911: Unable to scroll page if the filters modal closed by click outside of the modal due to missing verified label. kindly make sure that the PR has been verified |
In
merch-sidenav.js, when the filters modal is closed by clicking outside of it (rather than using the 'Close' button), the overlay emits a close event. On this event, we need to remove the merch-modal class; otherwise, the page will remain unscrollable.Related Milo PR: adobecom/milo#2933
Resolves: MWPW-158911
Test URLs:
(added a space after the 'scroll' to make this link invisible for PSI check)
For PSI check:
https://mwpw-158911-modal-scroll--cc--adobecom.hlx.live/products/animate/free-trial-download?martech=off