Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MWPW-154060: Preload most used scripts in head.html #240

Merged
merged 10 commits into from
Sep 10, 2024

Conversation

JasonHowellSlavin
Copy link
Contributor

  • Adds the setlibs function and some code in a script tag in the head to preload assets for the pages to increase loading speed.

Resolves: MWPW-154060

Test URLs:

Copy link

aem-code-sync bot commented Sep 5, 2024

Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed.
In case there are problems, just click a checkbox below to rerun the respective action.

  • Re-run PSI checks
  • Re-sync branch
Commits

Copy link

aem-code-sync bot commented Sep 5, 2024

Page Scores Audits Google
M /?martech=off PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
D /?martech=off PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI

@codecov-commenter
Copy link

codecov-commenter commented Sep 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.95%. Comparing base (97475e6) to head (74c9a11).

Additional details and impacted files
@@           Coverage Diff           @@
##            stage     #240   +/-   ##
=======================================
  Coverage   95.95%   95.95%           
=======================================
  Files          11       11           
  Lines        1088     1088           
=======================================
  Hits         1044     1044           
  Misses         44       44           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@meganthecoder
Copy link
Contributor

meganthecoder commented Sep 5, 2024

Screenshot 2024-09-05 at 1 35 12 PM

I'm seeing these warnings because of the way you're injecting the hrefs. Are we just ignoring them?

It creates some noise in the console, so maybe it would be better to build the elements with javascript.

@JasonHowellSlavin
Copy link
Contributor Author

Screenshot 2024-09-05 at 1 35 12 PM I'm seeing these warnings because of the way you're injecting the hrefs. Are we just ignoring them?

It creates some noise in the console, so maybe it would be better to build the elements with javascript.

Good point. I was trying to keep the JS as small as possible, but we don't want to jam up the console. Please take another look.

@Dli3 Dli3 added verified it's been E2E tested by someone (that isn't the PR requestor) ready for stage labels Sep 10, 2024
@Dli3 Dli3 self-assigned this Sep 10, 2024
@JasonHowellSlavin JasonHowellSlavin merged commit 0bde7a2 into stage Sep 10, 2024
8 checks passed
@JasonHowellSlavin JasonHowellSlavin deleted the head-prefetch-test branch September 10, 2024 17:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready for stage verified it's been E2E tested by someone (that isn't the PR requestor)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants