Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Release] Stage to Main #241

Merged
merged 14 commits into from
Sep 10, 2024
Merged

[Release] Stage to Main #241

merged 14 commits into from
Sep 10, 2024

Conversation

Copy link

aem-code-sync bot commented Sep 10, 2024

Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed.
In case there are problems, just click a checkbox below to rerun the respective action.

  • Re-run PSI checks
  • Re-sync branch
Commits

Copy link

aem-code-sync bot commented Sep 10, 2024

Page Scores Audits Google
M /?martech=off PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
D /?martech=off PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI

const miloDecorate = document.createElement('link');

miloStyles.setAttribute('as', 'style');
miloStyles.setAttribute('href', `${libs}/styles/styles.css`);

Check warning

Code scanning / CodeQL

Client-side URL redirect Medium

Untrusted URL redirection depends on a
user-provided value
.
tag.setAttribute('as', 'script');
})

miloUtils.setAttribute('href', `${libs}/utils/utils.js`);

Check warning

Code scanning / CodeQL

Client-side URL redirect Medium

Untrusted URL redirection depends on a
user-provided value
.
})

miloUtils.setAttribute('href', `${libs}/utils/utils.js`);
miloDecorate.setAttribute('href', `${libs}/utils/decorate.js`);

Check warning

Code scanning / CodeQL

Client-side URL redirect Medium

Untrusted URL redirection depends on a
user-provided value
.
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.98%. Comparing base (97475e6) to head (229705f).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #241      +/-   ##
==========================================
+ Coverage   95.95%   95.98%   +0.02%     
==========================================
  Files          11       11              
  Lines        1088     1095       +7     
==========================================
+ Hits         1044     1051       +7     
  Misses         44       44              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@meganthecoder
Copy link
Contributor

meganthecoder commented Sep 10, 2024

@JasonHowellSlavin Looks like you didn't squash and there are a lot of draft/test commits. Could you revert and do again?

Edit: We decided this isn't a good idea and are going to leave as is.

@JasonHowellSlavin JasonHowellSlavin merged commit 3945fbd into main Sep 10, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants