-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MWPW-154363: Add param anaylitics sandbox #239
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[Release] Stage to Main
…quest. There is a default, so we do not want to send anything if we do not find the metadata
JasonHowellSlavin
requested review from
Brandon32 and
meganthecoder
as code owners
September 5, 2024 16:19
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## stage #239 +/- ##
==========================================
+ Coverage 95.95% 95.98% +0.02%
==========================================
Files 11 11
Lines 1088 1095 +7
==========================================
+ Hits 1044 1051 +7
Misses 44 44 ☔ View full report in Codecov by Sentry. |
meganthecoder
approved these changes
Sep 5, 2024
Brandon32
approved these changes
Sep 9, 2024
Dli3
added
verified
it's been E2E tested by someone (that isn't the PR requestor)
ready for stage
labels
Sep 10, 2024
This was referenced Sep 10, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
sanboxgroup
metadata to the page that will send this group along with the post request.Context:
This will allow for us to use this endpoint for multiple uses in the interim while we get a runtime solution up and running. Arnfried has made the endpoint default to the original sandbox group if no group is sent with the POST request. This means by default we do not want to send a group unless it is found in the metadata. Additionally, probably a good idea for the authors to add the metadata
sandboxGroup
to the og page to have authoring parity.Needs to be tested with Eric.
Resolves: MWPW-NUMBER
Test URLs: