Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MWPW-154363: Add param anaylitics sandbox #239

Merged
merged 4 commits into from
Sep 10, 2024

Conversation

JasonHowellSlavin
Copy link
Contributor

  • Adds the ability to add a sanboxgroup metadata to the page that will send this group along with the post request.

Context:
This will allow for us to use this endpoint for multiple uses in the interim while we get a runtime solution up and running. Arnfried has made the endpoint default to the original sandbox group if no group is sent with the POST request. This means by default we do not want to send a group unless it is found in the metadata. Additionally, probably a good idea for the authors to add the metadata sandboxGroup to the og page to have authoring parity.

Needs to be tested with Eric.

Resolves: MWPW-NUMBER

Test URLs:

Dli3 and others added 3 commits August 7, 2024 10:13
…quest. There is a default, so we do not want to send anything if we do not find the metadata
Copy link

aem-code-sync bot commented Sep 5, 2024

Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed.
In case there are problems, just click a checkbox below to rerun the respective action.

  • Re-run PSI checks
  • Re-sync branch
Commits

Copy link

aem-code-sync bot commented Sep 5, 2024

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.98%. Comparing base (97475e6) to head (014b4dd).

Additional details and impacted files
@@            Coverage Diff             @@
##            stage     #239      +/-   ##
==========================================
+ Coverage   95.95%   95.98%   +0.02%     
==========================================
  Files          11       11              
  Lines        1088     1095       +7     
==========================================
+ Hits         1044     1051       +7     
  Misses         44       44              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Dli3 Dli3 self-assigned this Sep 10, 2024
@Dli3 Dli3 added verified it's been E2E tested by someone (that isn't the PR requestor) ready for stage labels Sep 10, 2024
@JasonHowellSlavin JasonHowellSlavin merged commit 229705f into stage Sep 10, 2024
9 checks passed
@JasonHowellSlavin JasonHowellSlavin deleted the add-param-anaylitics-sandbox branch September 10, 2024 18:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready for stage verified it's been E2E tested by someone (that isn't the PR requestor)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants