Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MWPW-134103 Fix Blog Regex #132

Merged
merged 1 commit into from
Jul 26, 2023
Merged

MWPW-134103 Fix Blog Regex #132

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions scripts/scripts.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -127,8 +127,7 @@ const CONFIG = {
{ iframe: 'https://adobe.ideacloud.com' },
],
htmlExclude: [
/business\.adobe\.com\/blog\/.*/,
/business\.adobe\.com\/(\w\w|(\w\w_\w\w))\/blog\/.*/,
/business\.adobe\.com\/(\w\w(_\w\w)?\/)?blog(\/.*)?/,
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it safe to assume that blog will not have pages for the africa, mena_en or mena_ar regions? This regex would not pass for those.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it safe to assume that blog will not have pages for the africa, mena_en or mena_ar regions? This regex would not pass for those.

the dx blog only supports regions au, uk, de, fr, ko, jp, so it should be okay in this instance!

],
};

Expand Down
Loading