-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MWPW-134103 Fix Blog Regex #132
Conversation
Hello, I'm Franklin Bot and I will run some test suites that validate the page speed.
|
Codecov Report
@@ Coverage Diff @@
## main #132 +/- ##
=======================================
Coverage 96.36% 96.36%
=======================================
Files 6 6
Lines 468 468
=======================================
Hits 451 451
Misses 17 17 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there no test URL that can be provided here?
@@ -127,8 +127,7 @@ const CONFIG = { | |||
{ iframe: 'https://adobe.ideacloud.com' }, | |||
], | |||
htmlExclude: [ | |||
/business\.adobe\.com\/blog\/.*/, | |||
/business\.adobe\.com\/(\w\w|(\w\w_\w\w))\/blog\/.*/, | |||
/business\.adobe\.com\/(\w\w(_\w\w)?\/)?blog(\/.*)?/, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it safe to assume that blog will not have pages for the africa
, mena_en
or mena_ar
regions? This regex would not pass for those.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it safe to assume that blog will not have pages for the
africa
,mena_en
ormena_ar
regions? This regex would not pass for those.
the dx blog only supports regions au, uk, de, fr, ko, jp, so it should be okay in this instance!
We only add .html extension in Stage and Prod so a branch is not going to show the this issue. There's the early return with Also you can see if you click on "Resources" in the gnav and click "Experience Cloud Blog" that the issue only appears in production, this is because the origins also have to match before it reaches the regex test, line 291. You can take a look at the branch but the only way to test is in production or with an online regex tester. |
appendHtmlPostfix
was only called durringloadArea
, but now that html postfix has been updatedappendHtmlToLink
is called more frequently withdecorateLinks
. [MWPW-131409] Update .html postfix milo#927appendHtmlToLink
function is now ran against the blog link.Resolves: MWPW-134103
Test URLs:
N/A