feat: [oppty] Pages with high click amount on non-interacting element #329
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ekremney
approved these changes
Aug 20, 2024
| } | ||
| } | ||
|
|
||
| function getRageClickOpporunities(rageClickInstances) { |
| return opportunities; | ||
| } | ||
|
|
||
| function handler(bundles) { |
There was a problem hiding this comment.
personal opinion and not blocking: I don't know how much memory overhead it would add but using functional js interfaces map, filter etc. would increase the readability
There was a problem hiding this comment.
as I was building a global structure rageClickInstances, felt like map wasn't best fit and running multiple operations of map/filter, will iterate the array more than once, so I thought its better to create the structure I want with single iteration.
|
This PR will trigger a minor release when merged. |
adobe-bot
pushed a commit
that referenced
this pull request
Aug 26, 2024
# [@adobe/spacecat-shared-rum-api-client-v2.8.0](https://github.com/adobe/spacecat-shared/compare/@adobe/spacecat-shared-rum-api-client-v2.7.4...@adobe/spacecat-shared-rum-api-client-v2.8.0) (2024-08-26) ### Features * [oppty] Pages with high click amount on non-interacting element ([#329](#329)) ([610a22f](610a22f))
|
🎉 This issue has been resolved in version @adobe/spacecat-shared-rum-api-client-v2.8.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TODO: Unit tests