Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: opportunities audit #360

Merged
merged 7 commits into from
Aug 26, 2024
Merged

Conversation

rpapani
Copy link
Contributor

@rpapani rpapani commented Aug 15, 2024

  • Container for opportunities audit.
  • experimentation opportunities will be added to experimentationOpportunities array
  • Added rageclick as an experimentation opportunity

Rageclick opportunity - adobe/spacecat-shared#329

Copy link

@ramboz ramboz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks overall good to me.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nitpicking: it feels more like a completely generic handler, than something specific to experiments.
The fact that you specifically populate a experimentationOpportunities sub-property is kinda a hint to me to expect more types down the road here 😉

Copy link

This PR will trigger a minor release when merged.

@rpapani rpapani changed the title feat: experimentation opportunities audit feat: opportunities audit Aug 15, 2024
@rpapani rpapani marked this pull request as ready for review August 16, 2024 00:26
@rpapani rpapani requested a review from ekremney August 16, 2024 00:26
@solaris007 solaris007 added the enhancement New feature or request label Aug 21, 2024
@rpapani rpapani merged commit 22128fd into main Aug 26, 2024
4 checks passed
@rpapani rpapani deleted the experimentation-opportunities-audit branch August 26, 2024 23:50
solaris007 pushed a commit that referenced this pull request Aug 26, 2024
# [1.28.0](v1.27.0...v1.28.0) (2024-08-26)

### Features

* opportunities audit ([#360](#360)) ([22128fd](22128fd))
@solaris007
Copy link
Member

🎉 This PR is included in version 1.28.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants