Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tests(broken-backlinks): reduce time to run tests #370

Merged
merged 1 commit into from
Aug 20, 2024
Merged

tests(broken-backlinks): reduce time to run tests #370

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 11 additions & 16 deletions test/audits/backlinks.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -96,6 +96,13 @@ describe('Backlinks Tests', function () {

const org = createOrganization({ name: 'org4' });

const brokenBacklinkWithTimeout = {
title: 'backlink that times out',
url_from: 'https://from.com/from-4',
url_to: 'https://foo.com/times-out',
domain_traffic: 500,
};

const auditResult = {
backlinks: [
{
Expand All @@ -116,12 +123,6 @@ describe('Backlinks Tests', function () {
url_to: 'https://foo.com/returns-429',
domain_traffic: 1000,
},
{
title: 'backlink that times out',
url_from: 'https://from.com/from-4',
url_to: 'https://foo.com/times-out',
domain_traffic: 500,
},
],
};

Expand Down Expand Up @@ -170,12 +171,6 @@ describe('Backlinks Tests', function () {
domain_traffic: 1000,
url_suggested: 'https://bar.foo.com/bar.html',
},
{
title: 'backlink that times out',
url_from: 'https://from.com/from-4',
url_to: 'https://foo.com/times-out',
domain_traffic: 500,
},
{
title: 'backlink that is not excluded',
url_from: 'https://from.com/from-not-excluded',
Expand Down Expand Up @@ -245,7 +240,7 @@ describe('Backlinks Tests', function () {

nock('https://foo.com')
.get('/times-out')
.delay(10000)
.delay(3010)
.reply(200);
});
afterEach(() => {
Expand Down Expand Up @@ -453,7 +448,7 @@ describe('Backlinks Tests', function () {
expect(context.log.info).to.have.been.calledWith('Successfully audited site2 for broken-backlinks type audit');
});

it('should filter out from audit result broken backlinks the ones that return ok(even with redirection)', async () => {
it('should filter out from audit result broken backlinks the ones that return ok (even with redirection)', async () => {
mockDataAccess.getSiteByID = sinon.stub().withArgs('site2').resolves(site2);
mockDataAccess.getTopPagesForSite.resolves([]);
mockDataAccess.getConfiguration = sinon.stub().resolves(configuration);
Expand All @@ -472,7 +467,7 @@ describe('Backlinks Tests', function () {
traffic_domain: 1500,
},
];
const allBacklinks = auditResult.backlinks.concat(fixedBacklinks);
const allBacklinks = auditResult.backlinks.concat(fixedBacklinks, brokenBacklinkWithTimeout);

nock('https://foo.com')
.get('/fixed')
Expand Down Expand Up @@ -502,7 +497,7 @@ describe('Backlinks Tests', function () {
},
auditResult: {
finalUrl: 'foo.com',
brokenBacklinks: auditResult.backlinks,
brokenBacklinks: auditResult.backlinks.concat(brokenBacklinkWithTimeout),
fullAuditRef: 'https://ahrefs.com/site-explorer/broken-backlinks?select=title%2Curl_from%2Curl_to%2Ctraffic_domain&limit=50&mode=prefix&order_by=domain_rating_source%3Adesc%2Ctraffic_domain%3Adesc&target=foo.com&output=json&where=%7B%22and%22%3A%5B%7B%22field%22%3A%22is_dofollow%22%2C%22is%22%3A%5B%22eq%22%2C1%5D%7D%2C%7B%22field%22%3A%22is_content%22%2C%22is%22%3A%5B%22eq%22%2C1%5D%7D%2C%7B%22field%22%3A%22domain_rating_source%22%2C%22is%22%3A%5B%22gte%22%2C29.5%5D%7D%2C%7B%22field%22%3A%22traffic_domain%22%2C%22is%22%3A%5B%22gte%22%2C500%5D%7D%2C%7B%22field%22%3A%22links_external%22%2C%22is%22%3A%5B%22lte%22%2C300%5D%7D%5D%7D',
},
};
Expand Down
Loading