tests(broken-backlinks): reduce time to run tests #370
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iuliag
requested review from
solaris007,
raji-unni,
dzehnder and
AndreiAlexandruParaschiv
solaris007
approved these changes
Aug 20, 2024
|
🎉 This PR is included in version 1.26.1 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reduce time to run tests.
Before: each test in the broken-backlinks suite that was hitting
filterOutValidBacklinkswas taking >3s to run because the setup included a broken backlink that when called was responding with a delay of 10000ms and fetch was waiting 3s for the response and then timing out.After this fix: there's a single test that is including this case:
should filter out from audit result broken backlinks the ones that return ok (even with redirection).