-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SITES-16562 - [Xwalk] Open Universal Editor from Franklin Sidekick #1
Open
jckautzmann
wants to merge
1
commit into
main
Choose a base branch
from
SITES-16562-open-editor
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,62 @@ | ||
async function getContentSourceUrl(owner, repo, ref) { | ||
const res = await fetch(`https://admin.hlx.page/sidekick/${owner}/${repo}/${ref}/env.json`); | ||
if (!res || !res.ok) { | ||
return null; | ||
} | ||
const env = await res.json(); | ||
if (!env) { | ||
return null; | ||
} | ||
return env.contentSourceUrl; | ||
} | ||
async function openAemEditor(event) { | ||
const { owner, repo, ref } = event.detail.data.config; | ||
const contentSourceUrl = await getContentSourceUrl(owner, repo, ref); | ||
const path = window.location.pathname; | ||
const editorUrl = `${contentSourceUrl}${path}?cmd=open`; | ||
// open the editor in a new tab | ||
window.open(editorUrl, '_blank'); | ||
} | ||
|
||
function getButton(sk, selector) { | ||
let btn = sk.shadowRoot.querySelector(selector); | ||
if (btn) { | ||
return btn; | ||
} | ||
return new Promise((resolve) => { | ||
const check = () => { | ||
btn = sk.shadowRoot.querySelector(selector); | ||
if (btn) { | ||
resolve(btn); | ||
} else { | ||
setTimeout(check, 100); | ||
} | ||
}; | ||
check(); | ||
}); | ||
} | ||
|
||
async function overrideEditButton(sk) { | ||
const oldEditBtn = await getButton(sk, '.edit.plugin'); | ||
const newEditBtn = await getButton(sk, '.aemedit.plugin'); | ||
oldEditBtn.replaceWith(newEditBtn); | ||
// hack to remove the original edit button that is generated again in the DOM | ||
const oldEditBtn1 = await getButton(sk, '.edit.plugin'); | ||
oldEditBtn1.remove(); | ||
sk.addEventListener('custom:aemedit', openAemEditor); | ||
} | ||
|
||
// eslint-disable-next-line import/prefer-default-export | ||
export function initSidekick() { | ||
let sk = document.querySelector('helix-sidekick'); | ||
if (sk) { | ||
// sidekick already loaded | ||
overrideEditButton(sk); | ||
} else { | ||
// wait for sidekick to be loaded | ||
document.addEventListener('sidekick-ready', () => { | ||
sk = document.querySelector('helix-sidekick'); | ||
overrideEditButton(sk); | ||
}, { once: true }); | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why do we need a new button actually? can we get the old button and just replace the click behaviour?
If so we would not need to add any sidekick config.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tried it but it didn't work because: