-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SITES-16562 - [Xwalk] Open Universal Editor from Franklin Sidekick #1
base: main
Are you sure you want to change the base?
Conversation
- edit the page with the AEM editor
Hello, I'm the AEM Code Sync Bot and I will run some test suites that validate the page speed.
|
|
async function overrideEditButton(sk) { | ||
const oldEditBtn = await getButton(sk, '.edit.plugin'); | ||
const newEditBtn = await getButton(sk, '.aemedit.plugin'); | ||
oldEditBtn.replaceWith(newEditBtn); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why do we need a new button actually? can we get the old button and just replace the click behaviour?
If so we would not need to add any sidekick config.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tried it but it didn't work because:
- the Edit button is disabled
- even if we enable it, the ootb logic is triggered when the button is clicked and it cannot be overridden
be2e07d doc: update README.md 287e35f feat: adopt the plugin api (#2) 9028520 fix: possible css leaking into pill overlay 162aab2 fix: improve anonymization for better gdpr/hippa compliance (#3) 0071dbd fix: audience pill activation a486023 fix: audience parsing 4789afd feat: limit the sampling rate 7fbef36 feat: limit the sampling rate (#1) 92e2abb fix: campaigns parsing 4467d3e fix: block-level experiments resolution 4438f52 doc: update readme 44a3aa4 fix: support installation in sub-directories a77433f style: properly inherit text color in the overlay git-subtree-dir: plugins/experience-decisioning git-subtree-split: be2e07ddce1d9c8d1622e6221f7a16593d87b811
Test URLs:
Before: https://main--wknd-xwalk--adobe-rnd.hlx.page/us/en
After: https://SITES-16562-open-editor--wknd-xwalk--adobe-rnd.hlx.page/us/en