Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(framework:skip) Refactor docker build matrix #4224

Merged
merged 4 commits into from
Nov 13, 2024

Conversation

Robert-Steiner
Copy link
Member

@Robert-Steiner Robert-Steiner commented Sep 17, 2024

Issue

Description

The Pull Request includes a refactor of the Docker workflows to minimize code duplication. This refactor makes it easier to add or remove Docker images without changing multiple workflow files. Specifically:

Related issues/PRs

Proposal

Explanation

Checklist

  • Implement proposed change
  • Write tests
  • Update documentation
  • Make CI checks pass
  • Ping maintainers on Slack (channel #contributions)

Any other comments?

@Robert-Steiner Robert-Steiner force-pushed the ci/refactor-docker-build-matrix branch 2 times, most recently from 6729a57 to 134926a Compare September 17, 2024 12:52
@Robert-Steiner Robert-Steiner changed the title refactor(framework) Refactor docker build matrix refactor(framework:skip) Refactor docker build matrix Sep 17, 2024
@Robert-Steiner Robert-Steiner self-assigned this Sep 17, 2024
@Robert-Steiner Robert-Steiner force-pushed the ci/refactor-docker-build-matrix branch 3 times, most recently from 77d02d8 to 60639ca Compare September 23, 2024 09:40
@Robert-Steiner Robert-Steiner marked this pull request as ready for review September 23, 2024 09:53
@Robert-Steiner Robert-Steiner force-pushed the ci/refactor-docker-build-matrix branch 2 times, most recently from 32e117a to 9a619bf Compare September 24, 2024 12:46
@Robert-Steiner Robert-Steiner marked this pull request as draft November 4, 2024 15:11
@Robert-Steiner Robert-Steiner force-pushed the ci/refactor-docker-build-matrix branch 6 times, most recently from 3535296 to 2bb4ff4 Compare November 13, 2024 08:49
Signed-off-by: Robert Steiner <[email protected]>
@Robert-Steiner Robert-Steiner force-pushed the ci/refactor-docker-build-matrix branch from 2bb4ff4 to f67d25a Compare November 13, 2024 09:26
@Robert-Steiner Robert-Steiner marked this pull request as ready for review November 13, 2024 09:26
@tanertopal tanertopal enabled auto-merge (squash) November 13, 2024 19:02
Copy link
Member

@tanertopal tanertopal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@tanertopal tanertopal merged commit 1308b8d into main Nov 13, 2024
55 checks passed
@tanertopal tanertopal deleted the ci/refactor-docker-build-matrix branch November 13, 2024 19:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants