feat(framework:skip) Add GPU base image to build matrix #4422
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Robert-Steiner
force-pushed
the
feat/add-gpu-build-matrix
branch
from
9792a9b to
f1e3582
Compare
5 tasks
Robert-Steiner
requested review from
tanertopal and
danieljanes
as code owners
Robert-Steiner
force-pushed
the
feat/add-gpu-build-matrix
branch
from
ff607e2 to
539c111
Compare
Signed-off-by: Robert Steiner <[email protected]>
Signed-off-by: Robert Steiner <[email protected]>
Signed-off-by: Robert Steiner <[email protected]>
Signed-off-by: Robert Steiner <[email protected]>
Signed-off-by: Robert Steiner <[email protected]>
Robert-Steiner
force-pushed
the
feat/add-gpu-build-matrix
branch
from
539c111 to
36a1701
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Description
This PR adds GPU base images to the build matrix script. However, it does not yet include the images in the output, so they will not be part of the nightly and unstable or the framework release pipeline. After this PR is merged, my plan is to revisit #4224 to move the hardcoded nightly and unstable build matrices into the build script, so we can manage them there.
After #4224 we can add the GPU images to the nightly and unstable build.
Test run: https://github.com/adap/flower/actions/runs/11663558509
Related issues/PRs
Proposal
Explanation
Checklist
#contributions)Any other comments?