Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(framework:skip) Move existing transport code to flwr/client/connection folder #4055

Open
wants to merge 2 commits into
base: intro-abc-conn
Choose a base branch
from
Open

refactor(framework:skip) Move existing transport code to flwr/client/connection folder #4055

wants to merge 2 commits into from
+14 −14

Conversation

panh99
Copy link
Contributor

@panh99 panh99 commented Aug 22, 2024 •
edited
Loading

@panh99 panh99 mentioned this pull request Aug 22, 2024
Open
@panh99 panh99 changed the base branch from main to intro-abc-conn August 22, 2024 09:20
@panh99 panh99 mentioned this pull request Aug 27, 2024
Open
@panh99 panh99 changed the base branch from intro-abc-conn to main August 27, 2024 09:09
@panh99 panh99 changed the base branch from main to intro-abc-conn August 27, 2024 09:17
@panh99 panh99 changed the base branch from intro-abc-conn to main September 6, 2024 10:21
@panh99 panh99 changed the base branch from main to intro-abc-conn September 10, 2024 07:23
@panh99 panh99 changed the base branch from intro-abc-conn to main September 13, 2024 13:51
@panh99 panh99 changed the base branch from main to intro-abc-conn September 19, 2024 23:24
@panh99 panh99 requested a review from chongshenng September 25, 2024 11:57
@panh99 panh99 force-pushed the mv-conns branch 2 times, most recently from 43417c8 to d152c35 Compare October 9, 2024 14:20
chongshenng
chongshenng approved these changes Oct 9, 2024
View reviewed changes
Copy link
Contributor

@chongshenng chongshenng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

chongshenng
chongshenng approved these changes Oct 11, 2024
View reviewed changes
Copy link
Contributor

@chongshenng chongshenng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@panh99 panh99 force-pushed the mv-conns branch 2 times, most recently from 452ae6e to 21192b9 Compare January 2, 2025 12:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chongshenng chongshenng chongshenng approved these changes

@danieljanes danieljanes Awaiting requested review from danieljanes danieljanes is a code owner

@tanertopal tanertopal Awaiting requested review from tanertopal tanertopal is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@panh99 @chongshenng