-
Notifications
You must be signed in to change notification settings - Fork 941
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(framework) Implement GrpcRereFleetConnection
, GrpcBidiConnection
, GrpcAdapterFleetConnection
, and RestFleetConnection
#4056
Open
panh99
wants to merge
24
commits into
mv-conns
Choose a base branch
from
implement-conns
base: mv-conns
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
9950584
to
8f39de4
Compare
367056b
to
fa3c285
Compare
da0156f
to
b372c42
Compare
@panh99 Would it make sense to have an intermediary |
452ae6e
to
21192b9
Compare
1d412ad
to
73fa4a6
Compare
73fa4a6
to
eb36760
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on:
FleetConnection
#4054flwr/client/connection
folder #4055grpc_rere_client/connection.py
toRereFleetConnection
, implementingConnection
class, andGrpcRereFleetConnection
, implementingRereFleetConnection
class.rest_client/connection.py
toRestFleetConnection
. It now inherits fromRereFleetConnection
and thus the code duplication is minimized.grpc_adapter_client/connection.py
toGrpcAdapterFleetConnection
, which also inherits fromRereFleetConnection
.grpc_client/connection.py
(thegrpc-bidi
transport) toGrpcBidiConnection
, implementingConnection
class.start_client_internal
.client_interceptor.py
and its unit tests accordingly.