Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(framework) Implement GrpcRereFleetConnection, GrpcBidiConnection, GrpcAdapterFleetConnection, and RestFleetConnection #4056

Open
wants to merge 24 commits into
base: mv-conns
Choose a base branch
from

Conversation

panh99
Copy link
Contributor

@panh99 panh99 commented Aug 22, 2024

Based on:

  1. feat(framework) Add the abstract base class FleetConnection #4054
  2. refactor(framework:skip) Move existing transport code to flwr/client/connection folder #4055
  • Migrated grpc_rere_client/connection.py to RereFleetConnection, implementing Connection class, and GrpcRereFleetConnection, implementing RereFleetConnection class.
  • Migrated part of rest_client/connection.py to RestFleetConnection. It now inherits from RereFleetConnection and thus the code duplication is minimized.
  • Migrated grpc_adapter_client/connection.py to GrpcAdapterFleetConnection, which also inherits from RereFleetConnection.
  • Migrated grpc_client/connection.py (the grpc-bidi transport) to GrpcBidiConnection, implementing Connection class.
  • Simplified the logic in the main loop of start_client_internal.
  • Updated client_interceptor.py and its unit tests accordingly.

@panh99 panh99 changed the base branch from main to mv-conns August 22, 2024 09:50
@panh99 panh99 changed the base branch from mv-conns to main August 27, 2024 09:12
@panh99 panh99 changed the base branch from main to mv-conns August 27, 2024 09:14
@panh99 panh99 changed the base branch from mv-conns to main August 27, 2024 09:15
@panh99 panh99 changed the base branch from main to mv-conns August 27, 2024 09:17
@panh99 panh99 changed the base branch from mv-conns to main September 6, 2024 10:31
@panh99 panh99 changed the base branch from main to mv-conns September 10, 2024 07:23
@panh99 panh99 changed the base branch from mv-conns to main September 13, 2024 13:51
@panh99 panh99 changed the base branch from main to mv-conns September 19, 2024 23:25
@panh99 panh99 requested a review from chongshenng September 25, 2024 11:57
@panh99 panh99 changed the base branch from mv-conns to main September 26, 2024 09:07
@panh99 panh99 changed the base branch from main to mv-conns September 26, 2024 15:33
@charlesbvll
Copy link
Member

Based on:

  1. feat(framework) Add the abstract base class Connection #4054
  2. refactor(framework:skip) Move existing transport code to flwr/client/connection folder #4055
  • Migrated grpc_rere_client/connection.py to GrpcRereConnection, implementing Connection class.
  • Migrated part of rest_client/connection.py to RestConnection. It now inherits from GrpcRereConnection and thus the code duplication is minimized.
  • Migrated grpc_adapter_client/connection.py to GrpcAdapterConnection, which also inherits from GrpcRereConnection.
  • Migrated grpc_client/connection.py (the grpc-bidi transport) to GrpcBidiConnection, implementing Connection class.
  • Simplified the logic in the main loop of start_client_internal.
  • Updated client_interceptor.py and its unit tests accordingly.

@panh99 Would it make sense to have an intermediary RereConnection that is inherited by both RestConnection and GrpcRereConnection? It somehow feels wrong to have RestConnection inherit from GrpcRereConnection eventhough it has nothing to do with gRPC. It's just a naming issue, but wdyt?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants