-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add REUSE.software compliant SPDX tags and pre-commit. #28
Merged
Merged
Changes from all commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,19 @@ | ||
# SPDX-FileCopyrightText: 2020 Diego Elio Pettenò | ||
# | ||
# SPDX-License-Identifier: Unlicense | ||
|
||
repos: | ||
- repo: https://github.com/python/black | ||
rev: 19.10b0 | ||
hooks: | ||
- id: black | ||
- repo: https://github.com/fsfe/reuse-tool | ||
rev: latest | ||
hooks: | ||
- id: reuse | ||
- repo: https://github.com/pre-commit/pre-commit-hooks | ||
rev: v2.3.0 | ||
hooks: | ||
- id: check-yaml | ||
- id: end-of-file-fixer | ||
- id: trailing-whitespace |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,3 +1,7 @@ | ||
# SPDX-FileCopyrightText: 2017 Tony DiCola for Adafruit Industries | ||
# | ||
# SPDX-License-Identifier: Unlicense | ||
|
||
python: | ||
version: 3 | ||
requirements_file: requirements.txt |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,3 +1,9 @@ | ||
<!-- | ||
SPDX-FileCopyrightText: 2014 Coraline Ada Ehmke | ||
SPDX-FileCopyrightText: 2019 Kattni Rembor for Adafruit Industries | ||
|
||
SPDX-License-Identifier: CC-BY-4.0 | ||
--> | ||
# Adafruit Community Code of Conduct | ||
|
||
## Our Pledge | ||
|
@@ -43,7 +49,7 @@ Examples of unacceptable behavior by participants include: | |
|
||
The goal of the standards and moderation guidelines outlined here is to build | ||
and maintain a respectful community. We ask that you don’t just aim to be | ||
"technically unimpeachable", but rather try to be your best self. | ||
"technically unimpeachable", but rather try to be your best self. | ||
|
||
We value many things beyond technical expertise, including collaboration and | ||
supporting others within our community. Providing a positive experience for | ||
|
@@ -74,9 +80,9 @@ You may report in the following ways: | |
In any situation, you may send an email to <[email protected]>. | ||
|
||
On the Adafruit Discord, you may send an open message from any channel | ||
to all Community Moderators by tagging @community moderators. You may | ||
also send an open message from any channel, or a direct message to | ||
@kattni#1507, @tannewt#4653, @Dan Halbert#1614, @cater#2442, | ||
to all Community Moderators by tagging @community moderators. You may | ||
also send an open message from any channel, or a direct message to | ||
@kattni#1507, @tannewt#4653, @danh#1614, @cater#2442, | ||
@sommersoft#0222, @Mr. Certainly#0472 or @Andon#8175. | ||
|
||
Email and direct message reports will be kept confidential. | ||
|
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Has there already been a discussion about switching from black to pre-commit? I'm not opposed to it, and after looking into it, it seems like a good option, but I think we may want to discuss it before changing it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also, from what I can tell, pre-commit is setup to actually modify the files. We had decided that we shouldn't do that since black and pylint do disagree every so often.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This was discussed briefly as part of adafruit/circuitpython#2887
This configuration is taken directly from adafruit/Adafruit_CircuitPython_TestRepo@18e383f
And is already applied to ESP32SPI as well (adafruit/Adafruit_CircuitPython_ESP32SPI@2077d83).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great. Thanks for linking that