Add REUSE.software compliant SPDX tags and pre-commit. #28
Conversation
This makes the project comply with the REUSE.software specifications.
The configuration is taken directly from adafruit/Adafruit_CircuitPython_TestRepo.
| - name: Pip install pylint, black, & Sphinx | ||
| - name: Pip install pylint, Sphinx, pre-commit |
There was a problem hiding this comment.
Has there already been a discussion about switching from black to pre-commit? I'm not opposed to it, and after looking into it, it seems like a good option, but I think we may want to discuss it before changing it.
There was a problem hiding this comment.
Also, from what I can tell, pre-commit is setup to actually modify the files. We had decided that we shouldn't do that since black and pylint do disagree every so often.
There was a problem hiding this comment.
This was discussed briefly as part of adafruit/circuitpython#2887
This configuration is taken directly from adafruit/Adafruit_CircuitPython_TestRepo@18e383f
And is already applied to ESP32SPI as well (adafruit/Adafruit_CircuitPython_ESP32SPI@2077d83).
There was a problem hiding this comment.
Great. Thanks for linking that
|
Anything left blocking this one? |
|
@dherrada This is waiting for you. |
Updating https://github.com/adafruit/Adafruit_CircuitPython_MCP230xx to 2.3.3 from 2.3.2: > Merge pull request adafruit/Adafruit_CircuitPython_MCP230xx#28 from Flameeyes/master
No description provided.