Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(policy,summary): updated ginkgo tests #769

Merged
merged 1 commit into from
Jul 13, 2023

Conversation

vishnusomank
Copy link
Contributor

Purpose of PR?:

To remove the flakiness of current ginkgo test and to use gRPC endpoints instead of karmor CLI to extract the data

Fixes #

Does this PR introduce a breaking change?

NO

If the changes in this PR are manually verified, list down the scenarios covered::

Additional information for reviewer? :
Mention if this PR is part of any design or a continuation of previous PRs

Checklist:

  • Bug fix. Fixes #
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update
  • PR Title follows the convention of <type>(<scope>): <subject>
  • Commit has unit tests
  • Commit has integration tests

Signed-off-by: Vishnu Soman <[email protected]>
Copy link
Contributor

@Ankurk99 Ankurk99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

mostly LGTM

@Prateeknandle Prateeknandle mentioned this pull request Jul 11, 2023
@wazir-ahmed wazir-ahmed merged commit 87a32b6 into accuknox:dev Jul 13, 2023
4 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants