Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improving tests #683

Closed
wants to merge 9 commits into from
Closed

improving tests #683

wants to merge 9 commits into from

Conversation

Prateeknandle
Copy link
Contributor

@Prateeknandle Prateeknandle commented Mar 9, 2023

fixes #682

changes:

  • capturing errors
  • removing bind points case for mysql pod summary

Signed-off-by: Prateeknandle <[email protected]>
Signed-off-by: Prateeknandle <[email protected]>
Signed-off-by: Prateeknandle <[email protected]>
Signed-off-by: Prateeknandle <[email protected]>
@Prateeknandle
Copy link
Contributor Author

FYI: Tests are working fine now. For summary it is still getting failed because summary data is unordered, when we get the new release it'll be fixed. I'll check tests once more when we get new release and then we can merge this pr.

@Prateeknandle Prateeknandle changed the title reducing flakiness of tests improving tests Jun 14, 2023
@Ankurk99
Copy link
Contributor

because summary data is unordered, when we get the new release it'll be fixed. I'll check tests once more when we get new release and then we can merge this pr.

How will this be fixed with the new release? Do we have any PR for that?

@Prateeknandle
Copy link
Contributor Author

How will this be fixed with the new release? Do we have any PR for that?

Fixed by #737

Signed-off-by: Prateeknandle <[email protected]>
@Prateeknandle
Copy link
Contributor Author

handled by #769

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] ginkgo tests are flaky
2 participants