Multitenancy v2 changes for prompt studio apps - Prompt studio core, Registry #720
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
harini-venkataraman
requested review from
muhammad-ali-e,
tahierhussain,
Deepak-Kesavan and
jagadeeswaran-zipstack
|
This was referenced Sep 20, 2024
muhammad-ali-e
requested changes
Sep 24, 2024
backend/prompt_studio/prompt_studio_core_v2/prompt_studio_helper.py
Outdated
Show resolved
Hide resolved
backend/prompt_studio/prompt_studio_core_v2/prompt_studio_helper.py
Outdated
Show resolved
Hide resolved
backend/prompt_studio/prompt_studio_core_v2/prompt_studio_helper.py
Outdated
Show resolved
Hide resolved
|
muhammad-ali-e
approved these changes
Sep 25, 2024
|
Duplication will be handled when we remove v1 later. |
| @@ -45,8 +46,8 @@ class Mode(models.TextChoices): | |||
| ) | |||
| tool_id = models.ForeignKey( | |||
| CustomTool, | |||
| on_delete=models.CASCADE, | |||
| related_name="tool_studio_prompts", | |||
| on_delete=models.SET_NULL, | |||
There was a problem hiding this comment.
@harini-venkataraman Not sure if this is intended.
There was a problem hiding this comment.
@harini-venkataraman Models look good overall.
Added a comment though.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Multitenancy v2 changes for Prompt studio, Prompt studio core and Prompt studio registry.
...
Why
Performance improvements.
...
How
...
Can this PR break any existing features. If yes, please list possible items. If no, please explain why. (PS: Admins do not merge the PR without this section filled)
No, the code is not referred.
...
Database Migrations
Env Config
Relevant Docs
Related Issues or PRs
#555
#503
#391
#564
Dependencies Versions
Notes on Testing
Untested code. Need to add migration files and test with migration.
Screenshots
Checklist
I have read and understood the Contribution Guidelines.