-
Notifications
You must be signed in to change notification settings - Fork 224
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MT-v2: Prompt studio core variable replacement minor changes from PR 611 #718
MT-v2: Prompt studio core variable replacement minor changes from PR 611 #718
Conversation
backend/prompt_studio/prompt_studio_core_v2/prompt_variable_service.py
Outdated
Show resolved
Hide resolved
|
Quality Gate failedFailed conditions |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, We can address conflict once the latest PRs came in
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@chandrasekharan-zipstack LGTM overall.
Suggest to add dev comments containing examples of what the regexes will ultimately match, as that really helps.
Duplication will be handled when we remove v1 later. |
What
Why
Can this PR break any existing features. If yes, please list possible items. If no, please explain why. (PS: Admins do not merge the PR without this section filled)
Notes on Testing
Screenshots
Checklist
I have read and understood the Contribution Guidelines.