Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

non-visible-tiles-optimization for multi-tile-composition #78

Merged
merged 74 commits into from
Nov 20, 2023

Conversation

ptahmose
Copy link
Contributor

@ptahmose ptahmose commented Nov 11, 2023

Description

  • Optimization of the tile-composition: before loading relevant subblocks, the tiles are checked whether they are visible (or whether they are completely overdrawn).
  • This optimization is implemented for the ISingleChannelTileAccessor and ISingleChannelScalingTileAccessor. Although this optimization is expected to give exact same results (as before/without optimization enabled) and there should be no reason for not enabling it, it can be enabled/disabled with the corresponding options-structure. It is disabled by default currently.
  • Fixed bug in CBitmapOperations::Fill_Gray8.

Fixes #75

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

  • extensive unittests for the optimization are provided with the PR

Checklist:

  • I followed the Contributing Guidelines.
  • I did a self-review.
  • I commented my code, particularly in hard-to-understand areas.
  • I updated the documentation.
  • I updated the version of libCZI following Versioning of libCZI depending on the type of change
    • Bug fix -> PATCH
    • New feature -> MINOR
    • Breaking change -> MAJOR
  • I have added tests that prove my fix is effective or that my feature works.
  • New and existing unit tests pass locally with my changes.

@ptahmose ptahmose marked this pull request as draft November 13, 2023 23:21
@ptahmose
Copy link
Contributor Author

I put the PR in draft state again, I want to rework it a bit.

@ptahmose ptahmose marked this pull request as ready for review November 18, 2023 16:43
@ptahmose ptahmose requested a review from a team November 20, 2023 08:24
@ptahmose ptahmose merged commit 6497366 into ZEISS:main Nov 20, 2023
15 checks passed
@ptahmose ptahmose deleted the jbl/#75-non-visible-tiles-optimization branch November 21, 2023 10:54
@ptahmose ptahmose mentioned this pull request Nov 21, 2023
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla Contributor License Agreement sent to Admin
Projects
None yet
Development

Successfully merging this pull request may close these issues.

optimize tile-composition: non-visible subblocks should be ignored
3 participants