-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bugfix for "visiblity optimization" #80
Merged
ptahmose
merged 14 commits into
ZEISS:main
from
ptahmose:jbl/bugfix_visiblity_optimization
Nov 21, 2023
Merged
bugfix for "visiblity optimization" #80
ptahmose
merged 14 commits into
ZEISS:main
from
ptahmose:jbl/bugfix_visiblity_optimization
Nov 21, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #80 +/- ##
=======================================
Coverage 65.11% 65.11%
=======================================
Files 81 81
Lines 10470 10470
=======================================
Hits 6818 6818
Misses 3652 3652
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
DaveyJonesBitPail
approved these changes
Nov 21, 2023
m-ringler
approved these changes
Nov 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is fixing a bug with the "non-visible-tile-optimization" introduced with #78.
A unit-test ensuring proper operation of this case was added.
Type of change
How Has This Been Tested?
locally and unit-test added
Checklist: