Fix the NoMethodError from #trace_discarded

[yuki24]

There seems to be two places where the trace_discarded method is called:

playwright-ruby-client/lib/playwright/channel_owners/tracing.rb

Lines 47 to 49 in c430525

	if @stacks_id
	@connection.local_utils.trace_discarded(@stacks_id)
	end

playwright-ruby-client/lib/playwright/channel_owners/tracing.rb

Lines 71 to 73 in c430525

	if @stacks_id
	@connection.local_utils.trace_discarded(@stacks_id)
	end

However, the actual LocalUtils class only implements tracing_discarded (tracing as opposed to trace). Not sure how I could this test this, so just opening up a draft PR and letting you know about this. Feel free to close this once this is fixed.

resolves #262

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment

Name	Status	Preview	Comments	Updated (UTC)
playwright-ruby-client	⬜️ Ignored (Inspect)	Visit Preview		Aug 16, 2023 6:58am

[YusukeIwaki]

Thank you for your contribution.

trace_discarded is right as playwright-python does.
https://github.com/search?q=repo%3Amicrosoft%2Fplaywright-python+trace_discarded&type=code

[YusukeIwaki]

https://github.com/microsoft/playwright/blob/d2165f3e2deb3dae0a79a23311248f41f93de64f/tests/library/tracing.spec.ts#L483C1-L485C69

diff --git a/spec/integration/tracing_spec.rb b/spec/integration/tracing_spec.rb
index 3045a24..f30a4ae 100644
--- a/spec/integration/tracing_spec.rb
+++ b/spec/integration/tracing_spec.rb
@@ -185,6 +185,10 @@ RSpec.describe 'tracing' do
         trace = File.join(dir, 'trace2.zip')
         context.tracing.stop_chunk(path: trace)
       end
+
+      context.tracing.start_chunk
+      page.click('"Click"')
+      context.tracing.stop_chunk # Should stop without a path.
     end
   end
 end

The code above would reproduce this issue.

[YusukeIwaki]

@yuki24 Thank you for your kind reporting and contribution.
playwright-ruby-client 1.37.1 and 1.36.1 would fix this issue. Please try it. Thank you :)

[yuki24]

@YusukeIwaki Thank you!