Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a spec for reproducing #262 #263

Merged
merged 1 commit into from
Aug 16, 2023
Merged

Add a spec for reproducing #262 #263

merged 1 commit into from
Aug 16, 2023

Conversation

YusukeIwaki
Copy link
Owner

before #261

- Gracefully stopping, waiting for requests to finish
=== puma shutdown: 2023-08-17 00:04:55 +0900 ===
- Goodbye!
  should work with multiple chunks (FAILED - 1)

Failures:

  1) tracing should work with multiple chunks
     Failure/Error: @connection.local_utils.trace_discarded(@stacks_id)
     
     NoMethodError:
       undefined method `trace_discarded' for #<localUtils>
       Did you mean?  tracing_discarded
     # ./lib/playwright/channel_owners/tracing.rb:48:in `do_stop_chunk'
     # ./lib/playwright/channel_owners/tracing.rb:30:in `stop_chunk'
     # ./lib/playwright_api/tracing.rb:70:in `stop_chunk'
     # ./spec/integration/tracing_spec.rb:191:in `block (3 levels) in <top (required)>'
     # ./lib/playwright/playwright_api.rb:121:in `block in wrap_block_call'
     # ./lib/playwright/channel_owners/browser.rb:41:in `new_context'
     # ./lib/playwright_api/browser.rb:125:in `new_context'
     # ./spec/spec_helper.rb:80:in `with_context'
     # ./spec/integration/tracing_spec.rb:168:in `block (2 levels) in <top (required)>'

after #261

- Gracefully stopping, waiting for requests to finish
=== puma shutdown: 2023-08-17 00:11:20 +0900 ===
- Goodbye!
  should work with multiple chunks

Finished in 19.11 seconds (files took 0.46779 seconds to load)
13 examples, 0 failures

@vercel
Copy link

vercel bot commented Aug 16, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Updated (UTC)
playwright-ruby-client ⬜️ Ignored (Inspect) Aug 16, 2023 3:13pm

@YusukeIwaki YusukeIwaki merged commit 8c169ab into main Aug 16, 2023
13 of 16 checks passed
@YusukeIwaki YusukeIwaki deleted the rspec-262 branch August 16, 2023 15:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant