Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

write_json: add option to include $scopeinfo cells #4837

Merged
merged 2 commits into from
Jan 10, 2025

Conversation

nakengelhardt
Copy link
Member

What are the reasons/motivation for this change?

Linty want to use the JSON output to build interactive netlist visualization, including of flattened designs. The information carried by $scopeinfo cells is valuable for that purpose.

Explain how this is achieved.

Add an argument to override the logic that currently skips $scopeinfo.

If applicable, please suggest to reviewers how they can test the change.

Testcase included

@povik
Copy link
Member

povik commented Jan 8, 2025

I think we can start emitting those unconditionally: #4084 (comment)

@nakengelhardt nakengelhardt added the merge-before-release Merge: PR should be included in the next release label Jan 8, 2025
Copy link
Member

@whitequark whitequark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Ideally nextpnr can benefit from these too.

@nakengelhardt nakengelhardt merged commit 7e3990b into main Jan 10, 2025
44 checks passed
@nakengelhardt nakengelhardt deleted the json_scopinfo_opt branch January 27, 2025 12:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merge-before-release Merge: PR should be included in the next release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants