Verific frontend: fix top_bound
/bottom_bound
attributes
#4815
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What are the reasons/motivation for this change?
Fixes two issues:
top_bound
/bottom_bound
attributes appear on SystemVerilog wirestop_bound
/bottom_bound
attributes are the wrong size on VHDL null ranges, and the value of the bounds may be truncated. It's not possible to tell the size of the wire from thetype_range
object in these cases.Explain how this is achieved.
import_attributes
can use to determine the size of the bounds.If applicable, please suggest to reviewers how they can test the change.
Expanded tests for many port types are included.