Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Verific frontend: fix top_bound/bottom_bound attributes #4815

Merged
merged 2 commits into from
Dec 12, 2024

Conversation

nakengelhardt
Copy link
Member

What are the reasons/motivation for this change?

Fixes two issues:

  1. Erroneous top_bound/bottom_bound attributes appear on SystemVerilog wires
  2. top_bound/bottom_bound attributes are the wrong size on VHDL null ranges, and the value of the bounds may be truncated. It's not possible to tell the size of the wire from the type_range object in these cases.

Explain how this is achieved.

  1. Only run on nets coming from VHDL
  2. Pass in an optional width hint that import_attributes can use to determine the size of the bounds.

If applicable, please suggest to reviewers how they can test the change.

Expanded tests for many port types are included.

@nakengelhardt nakengelhardt requested a review from mmicko December 12, 2024 10:53
Copy link
Member

@mmicko mmicko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nakengelhardt nakengelhardt merged commit f384eac into main Dec 12, 2024
44 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants