Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

write_xaiger: Get by without endianness helpers #4576

Merged
merged 1 commit into from
Sep 5, 2024

Conversation

povik
Copy link
Member

@povik povik commented Sep 3, 2024

What are the reasons/motivation for this change?

A clean-up

Explain how this is achieved.

Avoid any bswap helpers or the detection of host endianness when there's a portable way to write out a number in big endian: e.g. for 32-bit x you can do an equivalent of put(x >> 24); put(x >> 16); put(x >> 8); put(x);

@povik povik requested a review from aiju September 3, 2024 07:07
@povik povik requested a review from eddiehung as a code owner September 3, 2024 07:07
@povik povik requested a review from widlarizer September 5, 2024 10:35
Copy link
Collaborator

@widlarizer widlarizer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@povik povik merged commit 7e65b83 into YosysHQ:main Sep 5, 2024
23 checks passed
@povik povik deleted the xaiger-drop-bswap branch September 5, 2024 13:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants