Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add -blackbox flag to cutpoint pass #4566

Closed
wants to merge 2 commits into from

Conversation

RCoeurjoly
Copy link
Contributor

What are the reasons/motivation for this change?
Black/white boxes cannot be processed by sby, so they must be substituted by $anyseq cells.
Explain how this is achieved.
Adding a -blackbox flag to cutpoint.
If that flag is set, we find all modules that are black/white boxes, add their module names to the select pattern, and remove their black/whitebox attribute.
If applicable, please suggest to reviewers how they can test the change.

…es with $anyseq and removing their black/white attribute.
@RCoeurjoly RCoeurjoly marked this pull request as draft August 27, 2024 11:10
Copy link
Member

@nakengelhardt nakengelhardt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This approach won't work. extra_args can throw a message about invalid arguments, and the design must not be modified in any way prior to that. And given that the select argument is a stack-based sequence of instructions, appending something to the user-provided argument can have quite unpredictable and difficult-to-debug consequences. Please make a separate loop in the body of the pass that handles modifying the blackboxes directly.

@RCoeurjoly
Copy link
Contributor Author

This approach won't work. extra_args can throw a message about invalid arguments, and the design must not be modified in any way prior to that. And given that the select argument is a stack-based sequence of instructions, appending something to the user-provided argument can have quite unpredictable and difficult-to-debug consequences. Please make a separate loop in the body of the pass that handles modifying the blackboxes directly.

Yes, I think the approach followed in #4565 could be more succesful.
It takes care of not breaking passes that need to filter out blackboxes and at the same time enables blackbox selection when needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants