smtbmc: Fix two .yw handling related crashes #4431
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These came up when using the experimental incremental interface and are also in code that was recently refactored to support that interface.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These came up when using the experimental incremental interface and are also in code that was recently refactored to support that interface.
What are the reasons/motivation for this change?
This fixes observed crashes when using the incremental interface. In both cases a special case was missed and the specific changes handle the missed special case.
Explain how this is achieved.
smt_concataccept anything iterable in addition to tuples and lists, as it is sometimes called with generators.smt_extract_maskwith a completely empty mask and expecting a useful result, as it returns None in that case.If applicable, please suggest to reviewers how they can test the change.
The
check-sbyCI checks should be sufficient to ensure this doesn't regress anything.