-
Notifications
You must be signed in to change notification settings - Fork 929
ice40, ecp5: enable ABC9 by default #4019
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Based on discussion with @Ravenslofty I am in support of this change.
0cc2b40
to
1e6d9c1
Compare
1e6d9c1
to
3208247
Compare
Well, here goes nothing. |
I feel like this is a big enough change that it should have been discussed before merging... |
Would you be willing to humour me?
Ultimately, as the de-facto maintainer of ABC9, responsibility for fixing the ensuing bug reports falls on my shoulders, and I would rather have this out there and then get reverted so bugs can be found and fixed than the present "useful feature is not enabled by default and scares users with a big |
And this was so urgent that you could not wait until Monday to discuss these points at the dev JF? The release for this month is not out yet. |
Okay, I've reverted it. |
It's been four years since ABC9 was last proposed to be used by default. The arguments made back then still apply: results are superior compared to the default ABC flow, and we seem to have gotten most of the bugs fixed or worked around.
So, I'm once again asking for
your financial supportABC9 to be made the default on iCE40 and ECP5. I think using these two architectures as a baseline for wide adoption should quickly expose any other bugs in ABC9 that can then be fixed, given how popular they are over the others.