Added dynamic phase shift information into output and output file comments #175
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gatecat
reviewed
Jul 28, 2021
…hift occurs for all clocks per pulse.
rowanG077
commented
Jul 28, 2021
| float phase_count = ns_phase * (fvco * 1e6); | ||
| params.primary_cphase = phase_count; | ||
| int cphase = (int) phase_count; | ||
| params.primary_fphase = (int) ((phase_count - cphase) * 8); |
There was a problem hiding this comment.
This is the same calculation as done for secondary clocks is this correct?
rowanG077
commented
Jul 28, 2021
| @@ -422,7 +484,7 @@ void write_pll_config(const pll_params & params, const string &name, ofstream& f | |||
| file << " .CLKOP_ENABLE(\"ENABLED\"),\n"; | |||
| file << " .CLKOP_DIV(" << params.output_div << "),\n"; | |||
| file << " .CLKOP_CPHASE(" << params.primary_cphase << "),\n"; | |||
| file << " .CLKOP_FPHASE(0),\n"; | |||
| file << " .CLKOP_FPHASE(" << params.primary_fphase << "),\n"; | |||
There was a problem hiding this comment.
Why was 0 used here? The calculated fphase is not always 0.
There was a problem hiding this comment.
Thanks, I'll need to take some time to look into this as it's been a good while since I touched the ECP5 PLLs. I will keep this on my list though.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added documentation how much of a dynamic phase shift occurs for all clocks per pulse.